cuprated: add pop blocks command #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-p2p
github-actions
bot
removed
A-p2p
Boog900
commented
Sep 6, 2025
Comment on lines
+225
to
+233
| if self.seeds.len() < RX_SEEDS_CACHED { | ||
| let seed_heights = get_last_rx_seed_heights(new_height, RX_SEEDS_CACHED) | ||
| .split_at(self.seeds.len()) | ||
| .1 | ||
| .to_vec(); | ||
| let seed_hashes = get_block_hashes(seed_heights.clone(), database).await?; | ||
|
|
||
| self.seeds.extend(seed_heights.into_iter().zip(seed_hashes)); | ||
| } |
There was a problem hiding this comment.
The RX cache would panic if too many blocks were popped as it would have no seeds, this adds the seeds
consensus/context/src/weight.rs
Outdated
Comment on lines
140
to
151
| let old_long_term_weights = if let Some(new_long_term_start_height) = | ||
| chain_height.checked_sub(self.config.long_term_window + numb_blocks) | ||
| { | ||
| get_long_term_weight_in_range( | ||
| new_long_term_start_height..(new_long_term_start_height + numb_blocks), | ||
| database.clone(), | ||
| Chain::Main, | ||
| ) | ||
| .await? | ||
| } else { | ||
| vec![] | ||
| }; |
There was a problem hiding this comment.
the old way to do this for the weight cache was completely wrong
There was a problem hiding this comment.
although it was only a problem for reorgs over the short term window
SyntheticBird45
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.