feat: set devDependencies component.scope to excluded
#1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
…etadata Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
…roducible condition Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
Signed-off-by: AradhyaTiwari10 <aradhyafcb@gmail.com>
jkowalleck
changed the title
component.scope to excluded
jkowalleck
requested changes
Oct 30, 2025
| bom.metadata.tools.components.add(toolC) | ||
| } | ||
| if (!this.reproducible) { | ||
| if (this.reproducible) { |
There was a problem hiding this comment.
This seems to be an unintended change.
Please revert
| } else { | ||
| bom.serialNumber = Utils.BomUtility.randomSerialNumber() | ||
| bom.metadata.timestamp = new Date() | ||
| bom.metadata.properties.add( |
There was a problem hiding this comment.
This seems to be an unintended change.
Please revert
| } | ||
| // endregion metadata | ||
|
|
||
| // endregion metadata |
There was a problem hiding this comment.
This seems to be an unintended change.
Please revert
| PackagePrivate = 'cdx:npm:package:private', | ||
| PackageDevelopment = 'cdx:npm:package:development', | ||
| PackageInstallPath = 'cdx:npm:package:path', | ||
| BomReproducible = 'cdx:reproducible', |
There was a problem hiding this comment.
This seems to be an unintended change.
Please revert
| component.scope = Enums.ComponentScope.Excluded | ||
| } else if (isOptional) { | ||
| component.scope = Enums.ComponentScope.Optional | ||
| } else if (data.dev === true || data.devOptional === true) { |
There was a problem hiding this comment.
lets have a const for the term data.dev === true || data.devOptional === true - list like isOptional.
Could you add this const and use it where possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates SBOM generation to mark all components that appear only in devDependencies as "excluded", following the CycloneDX specification.
Details
Added a check for data.dev and data.devOptional flags in makeComponentWithPackageData.
Set component.scope = Enums.ComponentScope.Excluded for those components.
Ensures accurate differentiation between runtime (required) and development-only (excluded) dependencies.
Testing
All unit and integration tests pass (npm run test).
No lint errors except known deprecation warnings.
Related issue
Closes #1151