Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions cyclonedx_py/_internal/utils/cdx.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"""
CycloneDX related helpers and utils.
"""

from urllib.parse import urlparse
from collections.abc import Iterable
from re import compile as re_compile
from typing import Any, Optional
Expand Down Expand Up @@ -134,12 +134,52 @@ def licenses_fixup(component: 'Component') -> None:
'docs': ExternalReferenceType.DOCUMENTATION,
'changelog': ExternalReferenceType.RELEASE_NOTES,
'changes': ExternalReferenceType.RELEASE_NOTES,
'releasenotes': ExternalReferenceType.RELEASE_NOTES,
'news': ExternalReferenceType.RELEASE_NOTES,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"news","whatsnew" can be anything, not only release notes - i think this is undesired

'whatsnew': ExternalReferenceType.RELEASE_NOTES,
'history': ExternalReferenceType.RELEASE_NOTES,
# 'source': ExternalReferenceType.SOURCE-DISTRIBUTION,
'repository': ExternalReferenceType.VCS,
'github': ExternalReferenceType.VCS,
'chat': ExternalReferenceType.CHAT,
'sponsor': ExternalReferenceType.SOCIAL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sponsor","donation", "donate" - this is an undesired category mapping to "social".
thats not what social is for. see https://cyclonedx.org/docs/1.6/json/#externalReferences_items_type

'donation': ExternalReferenceType.SOCIAL,
'donate': ExternalReferenceType.SOCIAL
}
URL_MAP = {
Copy link
Member

@jkowalleck jkowalleck Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused symbol?
what is it for?

# Hosting
"github.com": ExternalReferenceType.VCS,
"gitlab.com": ExternalReferenceType.VCS,
"bitbucket.org": ExternalReferenceType.VCS,
# Social
"discord.gg": ExternalReferenceType.SOCIAL,
"discord.com": ExternalReferenceType.SOCIAL,
"discordapp.com": ExternalReferenceType.SOCIAL,
"glitter.im": ExternalReferenceType.SOCIAL,
"mastodon.com": ExternalReferenceType.SOCIAL,
"reddit.com": ExternalReferenceType.SOCIAL,
"slack.com": ExternalReferenceType.SOCIAL,
"youtube.com": ExternalReferenceType.SOCIAL,
"youtu.be": ExternalReferenceType.SOCIAL,
"twitter.com": ExternalReferenceType.SOCIAL,
"x.com": ExternalReferenceType.SOCIAL,
# Docs
"readthedocs.io": ExternalReferenceType.DOCUMENTATION,
# CI
"ci.appveyor.com": ExternalReferenceType.QUALITY_METRICS,
"circleci.com": ExternalReferenceType.QUALITY_METRICS,
"codecov.io":ExternalReferenceType.QUALITY_METRICS,
"coveralls.io": ExternalReferenceType.QUALITY_METRICS,
"travis-ci.com": ExternalReferenceType.QUALITY_METRICS,
"travis-ci.org": ExternalReferenceType.QUALITY_METRICS,
# PyPI
"cheeseshop.python.org": ExternalReferenceType.DISTRIBUTION,
"pypi.io": ExternalReferenceType.DISTRIBUTION,
"pypi.org": ExternalReferenceType.DISTRIBUTION,
"pypi.python.org": ExternalReferenceType.DISTRIBUTION,
# Python
"python.org": ExternalReferenceType.WEBSITE,
}

_NOCHAR_MATCHER = re_compile('[^a-z]')


Expand Down
Loading