feat: address stellar review feedback

Keyur279 · Keyur279 · commit 0769cffe1126 · 2025-07-30T05:26:46.000+05:30
diff --git a/apps/stellar_app/stellar_context.h b/apps/stellar_app/stellar_context.h
@@ -50,7 +50,8 @@ typedef struct {
 } stellar_config_t;
 
 // Stellar Memo types
-// See https://developers.stellar.org/docs/learn/encyclopedia/transactions-specialized/memos
+// See
+// https://developers.stellar.org/docs/learn/encyclopedia/transactions-specialized/memos
 typedef enum {
   STELLAR_MEMO_NONE = 0,
   STELLAR_MEMO_TEXT = 1,
@@ -59,8 +60,9 @@ typedef enum {
   STELLAR_MEMO_RETURN = 4
 } stellar_memo_type_t;
 
-// Stellar operation types  
-// See https://developers.stellar.org/docs/learn/fundamentals/transactions/list-of-operations
+// Stellar operation types
+// See
+// https://developers.stellar.org/docs/learn/fundamentals/transactions/list-of-operations
 typedef enum {
   STELLAR_OPERATION_CREATE_ACCOUNT = 0,
   STELLAR_OPERATION_PAYMENT = 1
diff --git a/apps/stellar_app/stellar_helpers.c b/apps/stellar_app/stellar_helpers.c
@@ -140,18 +140,22 @@ bool stellar_generate_address(const uint8_t *public_key, char *address) {
   }
 
   // Stellar address encoding (StrKey format)
-  // See https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0023.md
+  // See
+  // https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0023.md
   uint8_t payload[35];
-  payload[0] = 0x30;    // Account ID version byte (6 << 3 | 0 = STRKEY_PUBKEY OR STRKEY_ALG_ED25519)
+  payload[0] = 0x30;    // Account ID version byte (6 << 3 | 0 = STRKEY_PUBKEY
+                        // OR STRKEY_ALG_ED25519)
   memcpy(payload + 1, public_key, STELLAR_PUBKEY_RAW_SIZE);
 
   // CRC16-XModem checksum calculation
-  // See https://stellar.stackexchange.com/questions/255/which-cryptographic-algorithm-is-used-to-generate-the-secret-and-public-keys
+  // See
+  // https://stellar.stackexchange.com/questions/255/which-cryptographic-algorithm-is-used-to-generate-the-secret-and-public-keys
   uint16_t checksum = crc16(payload, 33);
   payload[33] = checksum & 0xFF;
   payload[34] = checksum >> 8;
 
   // RFC4648 base32 encoding without padding
-  base32_encode(payload, 35, address, STELLAR_ADDRESS_LENGTH, BASE32_ALPHABET_RFC4648);
+  base32_encode(
+      payload, 35, address, STELLAR_ADDRESS_LENGTH, BASE32_ALPHABET_RFC4648);
   return true;
 }
diff --git a/apps/stellar_app/stellar_helpers.h b/apps/stellar_app/stellar_helpers.h
@@ -64,9 +64,10 @@ bool stellar_derivation_path_guard(const uint32_t *path, uint8_t levels);
  * @brief Generates a Stellar address from a public key
  * @details Follows the Stellar address generation algorithm:
  * 1. Creates a payload with account ID type (0x30) and the public key
- * 2. Calculates CRC16 checksum  
+ * 2. Calculates CRC16 checksum
  * 3. Encodes the result using base32
- * See https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0023.md
+ * See
+ * https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0023.md
  *
  * @param public_key The 32-byte ED25519 public key
  * @param address Buffer to store the resulting address (must be at least
diff --git a/apps/stellar_app/stellar_txn.c b/apps/stellar_app/stellar_txn.c
@@ -459,7 +459,9 @@ static bool get_user_verification(void) {
   snprintf(operation_display,
            sizeof(operation_display),
            ui_text_stellar_operation,
-           decoded_txn->operation_type == STELLAR_OPERATION_CREATE_ACCOUNT ? "CREATE_ACCOUNT" : "PAYMENT");
+           decoded_txn->operation_type == STELLAR_OPERATION_CREATE_ACCOUNT
+               ? "CREATE_ACCOUNT"
+               : "PAYMENT");
   if (!core_confirmation(operation_display, stellar_send_error)) {
     return false;
   }
@@ -578,7 +580,8 @@ static int create_signature_base(const char *network_passphrase,
   } else if (tx->memo_type == STELLAR_MEMO_ID) {
     write_uint64_be(signature_base + offset, tx->memo.id);
     offset += 8;
-  } else if (tx->memo_type == STELLAR_MEMO_HASH || tx->memo_type == STELLAR_MEMO_RETURN) {
+  } else if (tx->memo_type == STELLAR_MEMO_HASH ||
+             tx->memo_type == STELLAR_MEMO_RETURN) {
     memcpy(signature_base + offset, tx->memo.hash, 32);
     offset += 32;
   }
@@ -599,15 +602,16 @@ static int create_signature_base(const char *network_passphrase,
   // Destination (type + pubkey)
   write_uint32_be(signature_base + offset, STELLAR_KEY_TYPE_ED25519);
   offset += 4;
-  memcpy(signature_base + offset, payment->destination, STELLAR_PUBKEY_RAW_SIZE);
+  memcpy(
+      signature_base + offset, payment->destination, STELLAR_PUBKEY_RAW_SIZE);
   offset += STELLAR_PUBKEY_RAW_SIZE;
-  
+
   // Asset (native) - only for PAYMENT operations
   if (tx->operation_type == STELLAR_OPERATION_PAYMENT) {
     write_uint32_be(signature_base + offset, STELLAR_ASSET_TYPE_NATIVE);
     offset += 4;
   }
-  
+
   // Amount
   write_uint64_be(signature_base + offset, payment->amount);
   offset += 8;
@@ -665,13 +669,15 @@ static bool sign_txn(der_sig_t *der_signature) {
 
   set_app_flow_status(STELLAR_SIGN_TXN_STATUS_SEED_GENERATED);
 
-  // Create HDNode from seed and derive private key using derive_hdnode_from_path
+  // Create HDNode from seed and derive private key using
+  // derive_hdnode_from_path
   HDNode node = {0};
-  if (!derive_hdnode_from_path(stellar_txn_context->init_info.derivation_path,
-                               stellar_txn_context->init_info.derivation_path_count,
-                               ED25519_NAME, 
-                               seed, 
-                               &node)) {
+  if (!derive_hdnode_from_path(
+          stellar_txn_context->init_info.derivation_path,
+          stellar_txn_context->init_info.derivation_path_count,
+          ED25519_NAME,
+          seed,
+          &node)) {
     stellar_send_error(ERROR_COMMON_ERROR_UNKNOWN_ERROR_TAG, 1);
     memzero(seed, sizeof(seed));
     memzero(&node, sizeof(HDNode));
diff --git a/apps/stellar_app/stellar_txn_helpers.c b/apps/stellar_app/stellar_txn_helpers.c
@@ -109,16 +109,18 @@ static uint64_t read_uint64_be_offset(const uint8_t *data, int *offset) {
   return (high << 32) | low;
 }
 
-static void read_account_offset(const uint8_t *data, int *offset, uint8_t *account) {
+static void read_account_offset(const uint8_t *data,
+                                int *offset,
+                                uint8_t *account) {
   memcpy(account, data + *offset, STELLAR_PUBKEY_RAW_SIZE);
   *offset += STELLAR_PUBKEY_RAW_SIZE;
 }
 
 static int read_string_offset(const uint8_t *data,
-                           int *offset,
-                           char *str,
-                           int max_len,
-                           int data_len) {
+                              int *offset,
+                              char *str,
+                              int max_len,
+                              int data_len) {
   if (*offset + 4 > data_len)
     return -1;
 
@@ -154,8 +156,8 @@ static int parse_memo_data(const uint8_t *xdr,
 
     case STELLAR_MEMO_TEXT: {
       char temp_memo[64];
-      int memo_len =
-          read_string_offset(xdr, offset, temp_memo, sizeof(temp_memo), xdr_len);
+      int memo_len = read_string_offset(
+          xdr, offset, temp_memo, sizeof(temp_memo), xdr_len);
       if (memo_len < 0) {
         return -1;
       }
@@ -199,15 +201,15 @@ static int parse_operation_data(const uint8_t *xdr,
   uint32_t has_source_account = read_uint32_be_offset(xdr, offset);
 
   if (has_source_account == 1) {
-    *offset += 36;  // Skip source account (4 bytes type + 32 bytes key)
+    *offset += 36;    // Skip source account (4 bytes type + 32 bytes key)
   } else if (has_source_account != 0) {
     return -1;
   }
 
   // Parse operation type
   uint32_t operation_type = read_uint32_be_offset(xdr, offset);
 
-  if (operation_type != STELLAR_OPERATION_PAYMENT && 
+  if (operation_type != STELLAR_OPERATION_PAYMENT &&
       operation_type != STELLAR_OPERATION_CREATE_ACCOUNT) {
     return -1;
   }
@@ -230,7 +232,7 @@ static int parse_operation_data(const uint8_t *xdr,
 
   // Parse amount (common for both operations)
   payment->amount = read_uint64_be_offset(xdr, offset);
-  
+
   return 0;
 }
 
@@ -271,7 +273,7 @@ int stellar_parse_transaction(const uint8_t *xdr,
   uint32_t preconditions_type = read_uint32_be_offset(xdr, &offset);
 
   if (preconditions_type == 1) {
-    offset += 16;  // Skip time bounds (8 + 8 bytes)
+    offset += 16;    // Skip time bounds (8 + 8 bytes)
   } else if (preconditions_type != 0) {
     return -1;
   }
diff --git a/common/libraries/util/utils.h b/common/libraries/util/utils.h
@@ -489,7 +489,7 @@ uint8_t string_to_escaped_string(const char *input,
 void write_uint32_be(uint8_t *buffer, uint32_t value);
 
 /**
- * @brief Write 64-bit value in big-endian format  
+ * @brief Write 64-bit value in big-endian format
  * @param buffer Output buffer
  * @param value 64-bit value to write
  */
diff --git a/src/constant_texts.h b/src/constant_texts.h
@@ -421,7 +421,7 @@ extern const char *ui_text_send_logs_prompt;
 
 // Stellar memo display texts
 #define UI_TEXT_STELLAR_MEMO_TEXT "Memo: \"%s\""
-#define UI_TEXT_STELLAR_MEMO_ID "Memo ID: %llu" 
+#define UI_TEXT_STELLAR_MEMO_ID "Memo ID: %llu"
 #define UI_TEXT_STELLAR_MEMO_HASH "Memo Hash: %s"
 #define UI_TEXT_STELLAR_OPERATION "Operation: %s"
 #define UI_TEXT_STELLAR_MEMO_UNKNOWN "Memo: (unknown type %u)"
