Skip to content

Commit 0969bd9

Browse files
fix: Invalid signature in constellation sign msg
1 parent 5aec696 commit 0969bd9

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

apps/constellation_app/constellation_sign_msg.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363

6464
#include <stddef.h>
6565
#include <stdint.h>
66+
#include <stdio.h>
6667

6768
#include "atca_helpers.h"
6869
#include "atca_status.h"
@@ -428,14 +429,16 @@ static size_t constellation_get_prefixed_msg_data(
428429
size_t msg_len = ctx->init.message_size;
429430

430431
char length_string[20] = "";
431-
size_t length_string_len =
432-
snprintf(length_string, sizeof(length_string), "%zu\n", msg_len);
432+
size_t length_string_len = sprintf(length_string, "%zu\n", msg_len);
433433

434434
size_t total_len = prefix_len + length_string_len + msg_len;
435435

436-
strncpy(prefixed_msg_data, prefix, prefix_len);
437-
strncat(prefixed_msg_data, length_string, length_string_len);
438-
strncat(prefixed_msg_data, (const char *)ctx->msg_data, msg_len);
436+
snprintf(prefixed_msg_data,
437+
total_len + 1, // +1 for \0
438+
"%s%s%s",
439+
prefix,
440+
length_string,
441+
(const char *)ctx->msg_data);
439442

440443
return total_len;
441444
}

0 commit comments

Comments
 (0)