chore(app): Review changes

Author: vrockz747

apps/inheritance_app/inheritance_auth_wallet.c

@@ -128,6 +128,9 @@ static bool auth_wallet_get_entropy() {
 
   if (status != CARD_OPERATION_SUCCESS ||
       msgs[0].encrypted_data_size > ENTROPY_SIZE_LIMIT) {
+    inheritance_send_error(ERROR_COMMON_ERROR_CORRUPT_DATA_TAG,
+                           ERROR_DATA_FLOW_INVALID_QUERY);
+    delay_scr_init(ui_text_inheritance_wallet_auth_fail, DELAY_TIME);
     return false;
   }
   set_app_flow_status(INHERITANCE_AUTH_WALLET_STATUS_CARD_TAPPED);
@@ -196,7 +199,13 @@ static bool send_result() {
  *****************************************************************************/
 
 void inheritance_auth_wallet(inheritance_query_t *query) {
-  auth = (auth_wallet_config_t *)cy_malloc(sizeof(auth_wallet_config_t));
+  auth = (auth_wallet_config_t *)malloc(sizeof(auth_wallet_config_t));
+  if (auth == NULL) {
+    inheritance_send_error(ERROR_COMMON_ERROR_UNKNOWN_ERROR_TAG,
+                           ERROR_DATA_FLOW_INVALID_DATA);
+    delay_scr_init(ui_text_inheritance_wallet_auth_fail, DELAY_TIME);
+    return;
+  }
   memzero(auth, sizeof(auth_wallet_config_t));
 
   memcpy(
@@ -212,4 +221,10 @@ void inheritance_auth_wallet(inheritance_query_t *query) {
       auth_wallet_get_pairs() && auth_wallet_get_signature() && send_result()) {
     delay_scr_init(ui_text_inheritance_wallet_auth_success, DELAY_TIME);
   }
+
+  memzero(auth, sizeof(auth_wallet_config_t));
+  if (NULL != auth) {
+    free(auth);
+    auth = NULL;
+  }
 }

apps/inheritance_app/inheritance_main.h

@@ -20,7 +20,6 @@
 
 #include "app_registry.h"
 #include "events.h"
-#include "inheritance/core.pb.h"
 #include "inheritance_context.h"
 /*****************************************************************************
  * MACROS AND DEFINES

apps/inheritance_app/inheritance_priv.h

@@ -13,9 +13,9 @@
 /*****************************************************************************
  * INCLUDES
  *****************************************************************************/
-#include <inheritance/core.pb.h>
 #include <stdint.h>
 
+#include "inheritance/core.pb.h"
 #include "inheritance_context.h"
 #include "nem.h"