fix: Unit tests

Author: muzaffarbhat07

apps/icp_app/icp_txn.c

@@ -99,7 +99,7 @@ uint8_t domain_separator[ICP_DOMAIN_SEPARATOR_LEN] =
 /*****************************************************************************
  * PRIVATE TYPEDEFS
  *****************************************************************************/
-typedef icp_sign_txn_signature_response_t sig_t;
+typedef icp_sign_txn_signature_response_t icp_sig_t;
 
 /*****************************************************************************
  * STATIC FUNCTION PROTOTYPES
@@ -216,7 +216,7 @@ static bool get_user_verification_for_token_txn(void);
  * @return false If signature could not be computed - maybe due to some error
  * during seed reconstruction phase
  */
-static bool sign_txn(sig_t *signature);
+static bool sign_txn(icp_sig_t *signature);
 
 /**
  * @brief Sends signature of the ICP unsigned txn to the host
@@ -229,7 +229,7 @@ static bool sign_txn(sig_t *signature);
  * @return false If the signature could not be sent - maybe due to and P0 event
  * or invalid request received from the host
  */
-static bool send_signature(icp_query_t *query, const sig_t *signature);
+static bool send_signature(icp_query_t *query, const icp_sig_t *signature);
 
 /*****************************************************************************
  * STATIC VARIABLES
@@ -616,7 +616,7 @@ static bool get_user_verification(void) {
   return get_user_verification_for_coin_txn();
 }
 
-static bool sign_txn(sig_t *signature) {
+static bool sign_txn(icp_sig_t *signature) {
   uint8_t seed[64] = {0};
   if (!reconstruct_seed(
           icp_txn_context->init_info.wallet_id, seed, icp_send_error)) {
@@ -688,7 +688,7 @@ static bool sign_txn(sig_t *signature) {
   return true;
 }
 
-static bool send_signature(icp_query_t *query, const sig_t *signature) {
+static bool send_signature(icp_query_t *query, const icp_sig_t *signature) {
   icp_result_t result = init_icp_result(ICP_RESULT_SIGN_TXN_TAG);
   result.sign_txn.which_response = ICP_SIGN_TXN_RESPONSE_SIGNATURE_TAG;
 
@@ -697,7 +697,7 @@ static bool send_signature(icp_query_t *query, const sig_t *signature) {
     return false;
   }
 
-  memcpy(&result.sign_txn.signature, signature, sizeof(sig_t));
+  memcpy(&result.sign_txn.signature, signature, sizeof(icp_sig_t));
 
   icp_send_result(&result);
   return true;
@@ -711,7 +711,7 @@ void icp_sign_transaction(icp_query_t *query) {
   icp_txn_context = (icp_txn_context_t *)malloc(sizeof(icp_txn_context_t));
   memzero(icp_txn_context, sizeof(icp_txn_context_t));
 
-  sig_t signature = {0};
+  icp_sig_t signature = {0};
 
   if (handle_initiate_query(query) && fetch_valid_input(query) &&
       get_user_verification() && sign_txn(&signature) &&

apps/near_app/near_txn_helpers.c

@@ -102,7 +102,7 @@ bool near_parse_transaction(const uint8_t *byte_array,
                             uint16_t byte_array_size,
                             near_unsigned_txn *utxn) {
   if (byte_array == NULL || utxn == NULL)
-    return;
+    return false;
   memzero(utxn, sizeof(near_unsigned_txn));
 
   uint16_t offset = 0;

common/libraries/crypto/mpz_operations/mpz_ecdsa.c

@@ -68,8 +68,11 @@
 
 #include "assert_conf.h"
 #include "mini-gmp.h"
+#include "rand.h"
 #include "rfc6979.h"
 
+#include "memzero.h"
+
 /*****************************************************************************
  * EXTERN VARIABLES
  *****************************************************************************/

src/wallet/wallet_unlock_flow.c

@@ -303,7 +303,7 @@ static wallet_unlock_state_e wallet_unlock_handler(
  *****************************************************************************/
 void wallet_unlock_flow(const Flash_Wallet *flash_wallet) {
   if ((NULL == flash_wallet) || (false == flash_wallet->is_wallet_locked)) {
-    return 0;
+    return;
   }
 
   wallet_unlock_state_e state = WALLET_UNLOCK_FETCH_CHALLENGE;

tests/apps/btc_app/btc_script_tests.c

@@ -58,6 +58,7 @@
 
 #include "btc_helpers.h"
 #include "btc_priv.h"
+#include "btc_script.h"
 #include "curves.h"
 #include "flash_config.h"
 #include "ltc_app.h"

tests/apps/near_app/near_helpers_tests.c

@@ -59,6 +59,7 @@
 #include "near.h"
 #include "near_context.h"
 #include "near_helpers.h"
+#include "near_txn_helpers.h"
 #include "unity_fixture.h"
 #include "utils.h"
 

tests/apps/near_app/near_txn_user_verification_tests.c

@@ -59,6 +59,7 @@
 #include "near.h"
 #include "near_context.h"
 #include "near_helpers.h"
+#include "near_txn_helpers.h"
 #include "near_txn_user_verification.h"
 #include "unity_fixture.h"
 #include "utils.h"

tests/common/util/byte_stream_tests.c

@@ -145,6 +145,10 @@ static byte_stream_writer_status_e dummy_request_write_cb(
   return BYTE_STREAM_WRITER_SUCCESS;
 }
 
+static byte_stream_writer_status_e failing_writer(byte_stream_t *stream) {
+  return BYTE_STREAM_WRITER_UNKNOWN_ERROR;
+}
+
 /*****************************************************************************
  * GLOBAL FUNCTIONS
  *****************************************************************************/
@@ -225,10 +229,6 @@ TEST(byte_stream_tests, returns_error_for_offset_greater_than_capacity) {
 }
 
 TEST(byte_stream_tests, returns_error_when_writer_fails) {
-  byte_stream_writer_status_e failing_writer(byte_stream_t * stream) {
-    return BYTE_STREAM_WRITER_UNKNOWN_ERROR;
-  }
-
   byte_stream_t stream = {.offset = 0,
                           .capacity = 10,
                           .stream_pointer = test_data,

tests/p0_events/p0_events_test.c

@@ -61,6 +61,9 @@
  *****************************************************************************/
 #include "p0_events_test.h"
 
+#include "memzero.h"
+#include "systick_timer_priv.h"
+
 /*****************************************************************************
  * EXTERN VARIABLES
  *****************************************************************************/

tests/ui/ui_events_test/ui_events_test.c

@@ -59,6 +59,8 @@
  */
 #include "ui_events_test.h"
 
+#include <string.h>
+
 #include "memzero.h"
 
 #if USE_SIMULATOR == 0