Merge pull request #666 from Cypherock/fix/stellar/reviews

fix: Resolve stellar review comments and fixes

Author: muzaffarbhat07

apps/stellar_app/stellar_context.h

@@ -68,27 +68,84 @@ typedef enum {
   STELLAR_OPERATION_PAYMENT = 1
 } stellar_operation_type_t;
 
+// Custom generic structure for Stellar operation data
+// So far we only support create account and payment operations with native
+// asset only
+typedef struct {
+  stellar_operation_type_t type;
+  uint8_t destination[STELLAR_PUBKEY_RAW_SIZE];
+  uint64_t amount;
+} stellar_operation_data_t;
+
+// Stellar preconditions types
+// See
+// https://developers.stellar.org/docs/learn/fundamentals/transactions/operations-and-transactions#preconditions
+// See
+// https://github.com/stellar/js-stellar-base/blob/master/xdr/curr/Stellar-transaction.x#L804
+typedef enum {
+  STELLAR_PRECOND_NONE = 0,
+  STELLAR_PRECOND_TIME = 1,
+  STELLAR_PRECOND_V2 = 2
+} stellar_preconditions_type_t;
+
+// Stellar time bounds structure
+// See
+// https://developers.stellar.org/docs/learn/fundamentals/transactions/operations-and-transactions#time-bounds
+// See
+// https://github.com/stellar/js-stellar-base/blob/master/xdr/curr/Stellar-transaction.x#L759
+typedef struct {
+  uint64_t min_time;
+  uint64_t max_time;
+} stellar_time_bounds_t;
+
+// Stellar preconditions structure
+// See
+// https://developers.stellar.org/docs/learn/fundamentals/transactions/operations
+typedef struct {
+  stellar_preconditions_type_t type;
+  union {
+    stellar_time_bounds_t
+        time_bounds;    // For PRECOND_TIME, only PRECOND_TIME is supported
+    // For PRECOND_V2, we can add more fields in future if needed
+  } preconditions;
+} stellar_preconditions_t;
+
+// Stellar transaction extension types
+// See
+// https://github.com/stellar/js-stellar-base/blob/master/xdr/curr/Stellar-transaction.x#L929
+typedef enum {
+  STELLAR_EXT_TYPE_EMPTY = 0,    // Empty extension, only supported type
+  // Other extension types can be added in future if needed
+} stellar_ext_type_t;
+
+// Stellar transaction extension structure
+// See
+// https://github.com/stellar/js-stellar-base/blob/master/xdr/curr/Stellar-transaction.x#L929
+typedef struct {
+  stellar_ext_type_t
+      type;    // Currently only STELLAR_EXT_TYPE_EMPTY is supported
+  // Other fields can be added in future if needed
+} stellar_transaction_extension_t;
+
 // Stellar transaction structures
-// See https://developers.stellar.org/docs/learn/encyclopedia/data-format/xdr
+// See
+// https://github.com/stellar/stellar-xdr/blob/curr/Stellar-transaction.x#L911
 typedef struct {
-  uint8_t source_account[32];
+  uint8_t source_account[STELLAR_PUBKEY_RAW_SIZE];
   uint64_t sequence_number;
   uint32_t fee;
-  uint32_t operation_count;
-  stellar_operation_type_t operation_type;
   stellar_memo_type_t memo_type;
   union {
     char text[29];       // STELLAR_MEMO_TEXT (max 28 bytes + 1 byte delimiter)
     uint64_t id;         // STELLAR_MEMO_ID
     uint8_t hash[32];    // STELLAR_MEMO_HASH or STELLAR_MEMO_RETURN(32 bytes)
   } memo;
+  uint32_t operation_count;
+  stellar_operation_data_t operations[1];    // Only one operation supported
+  stellar_preconditions_t preconditions;
+  stellar_transaction_extension_t ext;
 } stellar_transaction_t;
 
-typedef struct {
-  uint8_t destination[32];
-  uint64_t amount;
-} stellar_payment_t;
-
 typedef enum {
   STELLAR_NETWORK_MAINNET = 0,
   STELLAR_NETWORK_TESTNET = 1

apps/stellar_app/stellar_helpers.c

@@ -142,7 +142,7 @@ bool stellar_generate_address(const uint8_t *public_key, char *address) {
   // Stellar address encoding (StrKey format)
   // See
   // https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0023.md
-  uint8_t payload[35];
+  uint8_t payload[35] = {0};
   payload[0] = 0x30;    // Account ID version byte (6 << 3 | 0 = STRKEY_PUBKEY
                         // OR STRKEY_ALG_ED25519)
   memcpy(payload + 1, public_key, STELLAR_PUBKEY_RAW_SIZE);

apps/stellar_app/stellar_priv.h

@@ -33,8 +33,9 @@ typedef struct {
 
   // decoded transaction structures
   stellar_transaction_t *txn;
-  stellar_payment_t *payment;
-  size_t signature_data_len;
+
+  // holds the length of the xdr txn used for signing
+  uint32_t tagged_txn_len;
 } stellar_txn_context_t;
 
 /*****************************************************************************