From c2fce54fb848b432d2758ce4f9919669a19a5e39 Mon Sep 17 00:00:00 2001 From: TejasvOnly Date: Wed, 26 Mar 2025 23:24:03 -0700 Subject: [PATCH] fix: Use constant size for length check Instead of checking total size received from communication check the max size for Inheritance packet, because we are allocating buffer on stack --- apps/inheritance_app/inheritance_decrypt_data.c | 2 +- apps/inheritance_app/inheritance_encrypt_data.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/inheritance_app/inheritance_decrypt_data.c b/apps/inheritance_app/inheritance_decrypt_data.c index 17bfb18d8..1ac9e0b80 100644 --- a/apps/inheritance_app/inheritance_decrypt_data.c +++ b/apps/inheritance_app/inheritance_decrypt_data.c @@ -430,7 +430,7 @@ static bool inheritance_get_encrypted_data(inheritance_query_t *query) { if (false == query->decrypt.encrypted_data.has_chunk_payload || payload->chunk_index >= payload->total_chunks || - size + chunk->size > total_size) { + size + chunk->size > INHERITANCE_PACKET_MAX_SIZE) { SET_ERROR_TYPE(DECRYPTION_CHUNK_DATA_INVALID_ERROR); return false; } diff --git a/apps/inheritance_app/inheritance_encrypt_data.c b/apps/inheritance_app/inheritance_encrypt_data.c index 840c498b5..3746692b9 100644 --- a/apps/inheritance_app/inheritance_encrypt_data.c +++ b/apps/inheritance_app/inheritance_encrypt_data.c @@ -497,7 +497,7 @@ static bool inheritance_get_plain_data(inheritance_query_t *query) { if (false == query->encrypt.plain_data.has_chunk_payload || payload->chunk_index >= payload->total_chunks || - size + chunk->size > total_size) { + size + chunk->size > INHERITANCE_PACKET_MAX_SIZE) { SET_ERROR_TYPE(ENCRYPTION_CHUNK_DATA_INVALID_ERROR); return false; }