Skip to content

fix: Invalid signature in constellation sign msg #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

fix: Invalid signature in constellation sign msg #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions apps/constellation_app/constellation_sign_msg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@

#include <stddef.h>
#include <stdint.h>
#include <stdio.h>

#include "atca_helpers.h"
#include "atca_status.h"
Expand Down Expand Up @@ -428,14 +429,16 @@ static size_t constellation_get_prefixed_msg_data(
size_t msg_len = ctx->init.message_size;

char length_string[20] = "";
size_t length_string_len =
snprintf(length_string, sizeof(length_string), "%zu\n", msg_len);
size_t length_string_len = sprintf(length_string, "%zu\n", msg_len);

size_t total_len = prefix_len + length_string_len + msg_len;

strncpy(prefixed_msg_data, prefix, prefix_len);
strncat(prefixed_msg_data, length_string, length_string_len);
strncat(prefixed_msg_data, (const char *)ctx->msg_data, msg_len);
snprintf(prefixed_msg_data,
total_len + 1, // +1 for \0
"%s%s%s",
prefix,
length_string,
(const char *)ctx->msg_data);

return total_len;
}
Expand Down