Skip to content

Conversation

Keyur279
Copy link
Collaborator

@Keyur279 Keyur279 commented Jul 8, 2025

No description provided.

@Keyur279 Keyur279 changed the title Feat: Added Stellar Support feat: added stellar support Jul 8, 2025
@Keyur279 Keyur279 changed the title feat: added stellar support Feat added stellar support Jul 8, 2025
@Keyur279 Keyur279 force-pushed the feat/base-stellar branch 9 times, most recently from bf4aa28 to 57d9cab Compare July 8, 2025 23:58
@Keyur279 Keyur279 force-pushed the feat/base-stellar branch 2 times, most recently from f9209e0 to d1fd059 Compare July 21, 2025 20:35
@Keyur279 Keyur279 requested a review from muzaffarbhat07 July 21, 2025 20:40
@muzaffarbhat07 muzaffarbhat07 changed the base branch from main to develop July 22, 2025 09:03
Copy link
Collaborator

@muzaffarbhat07 muzaffarbhat07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync branch with 'develop'

Copy link
Collaborator

@muzaffarbhat07 muzaffarbhat07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And add references to docs wherever applicable. Like txn structure, address derivation, txn parsing, signing etc. Take reference from here.

@Keyur279 Keyur279 force-pushed the feat/base-stellar branch from d1fd059 to bdff72a Compare July 22, 2025 10:25
@Keyur279 Keyur279 force-pushed the feat/base-stellar branch from 3096fdb to f35100d Compare July 25, 2025 13:12
@Keyur279
Copy link
Collaborator Author

Added documentation references and synced with develop.

Copy link
Collaborator

@muzaffarbhat07 muzaffarbhat07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout the review comments. If you have any doubt, do let me know. We can discuss.

@Keyur279 Keyur279 force-pushed the feat/base-stellar branch from 0769cff to 5c155b4 Compare July 30, 2025 00:02
@Keyur279 Keyur279 requested a review from muzaffarbhat07 July 30, 2025 03:35
Copy link
Collaborator

@muzaffarbhat07 muzaffarbhat07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find transaction structure and parsing/encoding reference

Copy link
Collaborator

@muzaffarbhat07 muzaffarbhat07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review txn parsing and creating the signature base once I get some reference for it. We can have the call also for it

@Keyur279 Keyur279 force-pushed the feat/base-stellar branch from 10c996f to fefd570 Compare August 4, 2025 10:49
@muzaffarbhat07 muzaffarbhat07 changed the title Feat added stellar support feat: Added stellar support Aug 8, 2025
@muzaffarbhat07 muzaffarbhat07 merged commit cc3decc into develop Aug 8, 2025
6 checks passed
@muzaffarbhat07 muzaffarbhat07 deleted the feat/base-stellar branch August 8, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants