-
Notifications
You must be signed in to change notification settings - Fork 55
feat: Added stellar support #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf4aa28
to
57d9cab
Compare
f9209e0
to
d1fd059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sync branch with 'develop'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And add references to docs wherever applicable. Like txn structure, address derivation, txn parsing, signing etc. Take reference from here.
d1fd059
to
bdff72a
Compare
3096fdb
to
f35100d
Compare
Added documentation references and synced with develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checkout the review comments. If you have any doubt, do let me know. We can discuss.
0769cff
to
5c155b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find transaction structure and parsing/encoding reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will review txn parsing and creating the signature base once I get some reference for it. We can have the call also for it
10c996f
to
fefd570
Compare
e472a07
to
3578a93
Compare
fix: Resolve stellar review comments and fixes
No description provided.