Skip to content

Commit 123d591

Browse files
committed
fix tests
1 parent d9275d2 commit 123d591

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

adr/00004-tracking-usage.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Options considered:
1515

1616
- Google Analytics - we can tailor the settings to ensure that usage of Google Analytics is compliant
1717
with GDPR. This will require:
18+
1819
- enabling the anonymise IP setting
1920
- enabling pseudonymisation of IDs
2021
- including Google as a data processor in the privacy policy
@@ -24,12 +25,14 @@ Options considered:
2425
- ensure we have an agreement with Google Ireland Ltd and not Google LLC to ensure data is processed in Europe not the US
2526

2627
- Ahoy + Blazer - keep all tracking local and anonymous. This will require:
28+
2729
- storing all events in a local database
2830
- configuring without cookies and with IP masking
2931
- creating dashboards/queries in Blazer to visualise the usage
3032
- creating a recurring task to delete data at the end of the retention period
3133

3234
- [DfE Analytics](https://github.com/DFE-Digital/dfe-analytics) - preferred option within DfE. This will require:
35+
3336
- sending all events to a BigQuery database using the `dfe-analytics` Gem
3437
- configuring without cookies and with IP masking
3538
- creating dashboards/queries in Data Studio to visualise the usage

spec/mailers/teacher_mailer_spec.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,8 +559,7 @@
559559

560560
it do
561561
expect(subject).to include(
562-
"If you do not respond by 12 February 2020 " \
563-
"then your QTS application will be declined.",
562+
"This is your final opportunity to provide the required information.",
564563
)
565564
end
566565

0 commit comments

Comments
 (0)