Skip to content

Commit 6030d85

Browse files
committed
Fix error message location
1 parent 2a73b33 commit 6030d85

File tree

4 files changed

+13
-19
lines changed

4 files changed

+13
-19
lines changed

app/views/assessor_interface/assessment_sections/_english_language_exemption_content.html.erb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
<%= yield :assessment_section_top_of_form %>
2-
31
<% if application_form.english_language_citizenship_exempt %>
42
<h2 class="govuk-heading-m">English language exemption by birth/citizenship</h2>
53
<p class="govuk-body">

app/views/assessor_interface/assessment_sections/_form.html.erb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<%= form_with model: form, url: [:assessor_interface, view_object.application_form, view_object.assessment, @view_object.assessment_section], method: :put do |f| %>
2-
<%= f.govuk_error_summary %>
3-
4-
<%= yield :assessment_section_top_of_form %>
2+
<% content_for(:error_summary) { f.govuk_error_summary } %>
53

64
<% if view_object.show_english_language_exemption_checkbox? %>
75
<% if view_object.assessment_section.personal_information? %>

app/views/assessor_interface/assessment_sections/show.html.erb

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,31 +5,28 @@
55

66
<% content_for :page_title, title_with_error_prefix(t(".title.#{preliminary_key}.#{section_key}"), error: @form.errors.any?) %>
77
<% content_for :back_link_url, assessor_interface_application_form_path(@application_form) %>
8-
<% content_for(:assessment_section_top_of_form) do %>
9-
<%= render "linked_application_forms",
10-
application_forms_contact_email_used_as_teacher: @view_object.work_history_application_forms_contact_email_used_as_teacher,
11-
application_forms_contact_email_used_as_reference: @view_object.work_history_application_forms_contact_email_used_as_reference %>
128

13-
<%= render "shared/assessor_header",
9+
<%= render "linked_application_forms",
10+
application_forms_contact_email_used_as_teacher: @view_object.work_history_application_forms_contact_email_used_as_teacher,
11+
application_forms_contact_email_used_as_reference: @view_object.work_history_application_forms_contact_email_used_as_reference %>
12+
13+
<%= render "shared/assessor_header",
1414
title: t(".title.#{preliminary_key}.#{section_key}"),
1515
application_form: @view_object.application_form %>
1616

17-
<% if @view_object.show_teacher_name_and_date_of_birth? %>
18-
<h2 class="govuk-heading-m"><%= @view_object.teacher_name_and_date_of_birth %></h2>
19-
<% end %>
17+
<% if @view_object.show_teacher_name_and_date_of_birth? %>
18+
<h2 class="govuk-heading-m"><%= @view_object.teacher_name_and_date_of_birth %></h2>
19+
<% end %>
2020

21-
<%= render "#{section_key}_summary",
21+
<%= render "#{section_key}_summary",
2222
region: @view_object.region,
2323
application_form: @view_object.application_form,
2424
assessment: @view_object.assessment,
2525
assessment_section: @view_object.assessment_section,
2626
highlighted_work_history_contact_emails: @view_object.highlighted_work_history_contact_emails %>
27-
<% end %>
2827

2928
<% if @view_object.show_form? %>
3029
<%= render "form", form: @form, view_object: @view_object %>
31-
<% elsif @view_object.show_english_language_exemption_content? %>
30+
<% else @view_object.show_english_language_exemption_content? %>
3231
<%= render "english_language_exemption_content", application_form: @view_object.application_form %>
33-
<% else %>
34-
<%= yield :assessment_section_top_of_form %>
3532
<% end %>

app/views/layouts/application.html.erb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<% end %>
2727

2828
<%= govuk_skip_link %>
29-
29+
3030
<%= render partial: "shared/header" %>
3131

3232
<div class="govuk-width-container">
@@ -49,6 +49,7 @@
4949

5050
<div class="govuk-width-container">
5151
<%= govuk_back_link(href: yield(:back_link_url)) unless yield(:back_link_url).blank? %>
52+
<%= yield(:error_summary) %>
5253
<main class="govuk-main-wrapper" id="main-content" role="main">
5354
<%= render(FlashMessage::Component.new(flash: flash)) %>
5455
<%= content_for?(:content) ? yield(:content) : yield %>

0 commit comments

Comments
 (0)