Improvements and testing

Author: Hassanmir92

app/view_objects/assessor_interface/assessment_section_view_object.rb

@@ -47,6 +47,10 @@ def notes_placeholder_key_for(failure_reason:)
       build_key(failure_reason, "placeholder")
     end
 
+    def selected_work_histories_for(failure_reason:)
+      selected_failure_reasons.find_by(key: failure_reason)&.work_histories
+    end
+
     def show_form?
       return true if preliminary?
 

app/views/assessor_interface/assessment_sections/_form.html.erb

@@ -82,7 +82,7 @@
                                     hint: { text: t(view_object.notes_hint_key_for(failure_reason:)) },
                                     placeholder: t(view_object.notes_placeholder_key_for(failure_reason:)),
                                     disabled: view_object.disable_form? %>
-              <% if FailureReasons.chooses_work_history?(failure_reason) || view_object.selected_failure_reasons.find_by(key: failure_reason)&.work_histories.present? %>
+              <% if FailureReasons.chooses_work_history?(failure_reason) || view_object.selected_work_histories_for(failure_reason:).present? %>
                 <%= f.govuk_check_boxes_fieldset :"#{failure_reason}_work_history_checked", legend: { size: "s" } do %>
                   <% view_object.work_histories.each do |work_history| %>
                     <%= f.govuk_check_box :"#{failure_reason}_work_history_checked", work_history.id, label: { text: work_history.school_name }, disabled: view_object.disable_form? %>

app/views/assessor_interface/further_information_requests/new.html.erb

@@ -4,7 +4,7 @@
 <h1 class="govuk-heading-xl">Check the information you’re asking the applicant for</h1>
 
 <% @further_information_request.items.group_by(&:failure_reason_key).each do |failure_reason_key, items| %>
-  <% if failure_reason_key == FailureReasons::UNRECOGNISED_REFERENCES %>
+  <% if FailureReasons.chooses_work_history?(failure_reason_key) %>
     <section class="app-further-information-request-item">
       <h2 class="govuk-heading-m">Reason for request</h2>
       <% if items.size == 1 %>

spec/system/assessor_interface/checking_submitted_details_spec.rb

@@ -551,7 +551,7 @@ def application_form
           :work_history,
           assessment: application_form.assessment,
           failure_reasons: %w[
-            school_details_cannot_be_verified
+            unrecognised_references
             identification_document_expired
           ],
         )

spec/view_objects/assessor_interface/assessment_section_view_object_spec.rb

@@ -199,6 +199,52 @@
     end
   end
 
+  describe "#selected_work_histories_for" do
+    subject(:selected_work_histories_for) do
+      view_object.selected_work_histories_for(failure_reason:)
+    end
+
+    let(:application_form) do
+      create(:application_form, :with_work_history, region:)
+    end
+    let(:failure_reason) { FailureReasons::UNRECOGNISED_REFERENCES }
+    let(:work_histories) { application_form.work_histories }
+    let(:selected_failure_reason) do
+      create :selected_failure_reason,
+             key: failure_reason,
+             assessment_section:,
+             work_histories:
+    end
+
+    before do
+      selected_failure_reason
+    end
+
+    it "returns the work histories attached to the selected failure reason" do
+      expect(selected_work_histories_for).to eq(application_form.work_histories)
+    end
+
+    context "when there is no work history attached" do
+      let(:work_histories) { [] }
+
+      it "returns the empty" do
+        expect(selected_work_histories_for).to be_empty
+      end
+    end
+
+    context "when the selected failure reason is not on assessment section" do
+      let(:selected_failure_reason) do
+        create :selected_failure_reason,
+               key: FailureReasons::SCHOOL_DETAILS_CANNOT_BE_VERIFIED,
+               assessment_section:
+      end
+
+      it "returns nil" do
+        expect(selected_work_histories_for).to be_nil
+      end
+    end
+  end
+
   describe "#show_form?" do
     subject(:show_form?) { view_object.show_form? }