Merge pull request #2871 from DFE-Digital/AQTS-1104-bug-ordering-of-references-changes-for-prioritisation-when-checking-references

Hassanmir92 · web-flow · commit 720d9c9ab927 · 2025-09-03T15:07:24.000+01:00
[AQTS-1104] Order the list of schools for both prioritisation setting check and reference checks by the school/institute name
diff --git a/app/controllers/assessor_interface/prioritisation_reference_requests_controller.rb b/app/controllers/assessor_interface/prioritisation_reference_requests_controller.rb
@@ -103,7 +103,10 @@ def review_form_params
 
     def prioritisation_reference_requests
       @prioritisation_reference_requests ||=
-        assessment.prioritisation_reference_requests
+        assessment
+          .prioritisation_reference_requests
+          .includes(:work_history)
+          .order("work_histories.school_name")
     end
 
     def assessment
diff --git a/app/controllers/assessor_interface/prioritisation_work_history_checks_controller.rb b/app/controllers/assessor_interface/prioritisation_work_history_checks_controller.rb
@@ -80,6 +80,7 @@ def prioritisation_work_history_checks
               reference: params[:application_form_reference],
             },
           )
+          .order("work_histories.school_name")
     end
 
     def prioritisation_work_history_check

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,7 @@ def prioritisation_work_history_checks`
`80`	`80`	`reference: params[:application_form_reference],`
`81`	`81`	`},`
`82`	`82`	`)`
	`83`	`+ .order("work_histories.school_name")`
`83`	`84`	`end`
`84`	`85`
`85`	`86`	`def prioritisation_work_history_check`