Sorting the FI items by reason title

Author: Hassanmir92

app/view_objects/teacher_interface/further_information_request_view_object.rb

@@ -88,23 +88,26 @@ def items_by_assessment_section
     end
 
     def task_list_items(items)
-      items.map do |item|
-        {
-          title: item_name(item),
-          description: item_description(item),
-          value_title: item_value_title(item),
-          value: item_value(item),
-          assessor_note: item.failure_reason_assessor_feedback,
-          href: [
-            :edit,
-            :teacher_interface,
-            :application_form,
-            further_information_request,
-            item,
-          ],
-          status: item.status,
-        }
-      end
+      list_items =
+        items.map do |item|
+          {
+            title: item_name(item),
+            description: item_description(item),
+            value_title: item_value_title(item),
+            value: item_value(item),
+            assessor_note: item.failure_reason_assessor_feedback,
+            href: [
+              :edit,
+              :teacher_interface,
+              :application_form,
+              further_information_request,
+              item,
+            ],
+            status: item.status,
+          }
+        end
+
+      list_items.sort_by { |item| item[:title] }
     end
 
     def item_value_title(item)

spec/system/teacher_interface/further_information_spec.rb

@@ -298,7 +298,7 @@ def text_task_list_item
   def text_check_answers_item
     teacher_check_further_information_request_answers_page
       .summary_lists
-      .second
+      .first
       .rows
       .first
   end
@@ -318,7 +318,7 @@ def document_task_list_item
   def document_check_answers_item
     teacher_check_further_information_request_answers_page
       .summary_lists
-      .first
+      .third
       .rows
       .first
   end