Merge pull request #2883 from DFE-Digital/AQTS-1172-dev-application-stuck-in-verification-after-reverse-decision-on-a-decline

[AQTS-1172] Block verification update for qualification and lops if the application is no longer in verification

Author: Hassanmir92

app/controllers/assessor_interface/qualification_requests_controller.rb

@@ -236,7 +236,12 @@ def update_verify_failed
     end
 
     def edit_review
-      @form = RequestableReviewForm.new(requestable:)
+      @form =
+        RequestableReviewForm.new(
+          requestable:,
+          passed: requestable.review_passed,
+          note: requestable.review_note,
+        )
     end
 
     def update_review

app/controllers/assessor_interface/reference_requests_controller.rb

@@ -15,7 +15,12 @@ def index
     end
 
     def edit_review
-      @form = RequestableReviewForm.new(requestable:)
+      @form =
+        RequestableReviewForm.new(
+          requestable:,
+          passed: requestable.review_passed,
+          note: requestable.review_note,
+        )
     end
 
     def update_review

app/views/assessor_interface/professional_standing_requests/edit_verify.html.erb

@@ -1,5 +1,6 @@
 <% content_for :page_title, title_with_error_prefix("Record LoPS response", error: @form.errors.any?) %>
 <% content_for :back_link_url, assessor_interface_application_form_assessment_professional_standing_request_path %>
+<% can_update_verify_lops_request = @assessment.verify? && policy([:assessor_interface, @professional_standing_request]).update_verify? %>
 
 <%= form_with model: @form, url: [:verify, :assessor_interface, @application_form, @assessment, :professional_standing_request] do |f| %>
   <%= f.govuk_error_summary %>
@@ -23,17 +24,19 @@
                 "Does the response confirm that the LoPS is valid?" %>
 
   <%= f.govuk_radio_buttons_fieldset :passed, legend: { text: legend, size: "s" } do %>
-    <%= f.govuk_radio_button :passed, :true, link_errors: true %>
+    <%= f.govuk_radio_button :passed, :true, link_errors: true, disabled: !can_update_verify_lops_request %>
 
     <% if @professional_standing_request.expired? %>
-      <%= f.govuk_radio_button :passed, :false do %>
-        <%= f.govuk_radio_button :received, :true %>
-        <%= f.govuk_radio_button :received, :false %>
+      <%= f.govuk_radio_button :passed, :false, disabled: !can_update_verify_lops_request do %>
+        <%= f.govuk_radio_button :received, :true, disabled: !can_update_verify_lops_request %>
+        <%= f.govuk_radio_button :received, :false, disabled: !can_update_verify_lops_request %>
       <% end %>
     <% else %>
-      <%= f.govuk_radio_button :passed, :false %>
+      <%= f.govuk_radio_button :passed, :false, disabled: !can_update_verify_lops_request %>
     <% end %>
   <% end %>
 
-  <%= render "shared/assessor_interface/continue_cancel_button", f: %>
+  <%= f.govuk_submit disabled: !can_update_verify_lops_request do %>
+    <%= render "shared/assessor_interface/cancel_link" %>
+  <% end %>
 <% end %>

app/views/assessor_interface/qualification_requests/edit_verify.html.erb

@@ -1,4 +1,5 @@
 <% title = "Record Ecctis response" %>
+<% can_update_verify_qualification_request = @assessment.verify? && policy([:assessor_interface, @qualification_request]).update_verify? %>
 
 <% content_for :page_title, title_with_error_prefix(title, error: @form.errors.any?) %>
 <% content_for :back_link_url, back_history_path(default: assessor_interface_application_form_path(@application_form)) %>
@@ -30,17 +31,19 @@
                 "Does the response confirm that the qualification is valid?" %>
 
   <%= f.govuk_radio_buttons_fieldset :passed, legend: { text: legend } do %>
-    <%= f.govuk_radio_button :passed, :true, link_errors: true %>
+    <%= f.govuk_radio_button :passed, :true, link_errors: true, disabled: !can_update_verify_qualification_request %>
 
     <% if @qualification_request.expired? %>
-      <%= f.govuk_radio_button :passed, :false do %>
-        <%= f.govuk_radio_button :received, :true %>
-        <%= f.govuk_radio_button :received, :false %>
+      <%= f.govuk_radio_button :passed, :false, disabled: !can_update_verify_qualification_request do %>
+        <%= f.govuk_radio_button :received, :true, disabled: !can_update_verify_qualification_request %>
+        <%= f.govuk_radio_button :received, :false, disabled: !can_update_verify_qualification_request %>
       <% end %>
     <% else %>
-      <%= f.govuk_radio_button :passed, :false %>
+      <%= f.govuk_radio_button :passed, :false, disabled: !can_update_verify_qualification_request %>
     <% end %>
   <% end %>
 
-  <%= render "shared/assessor_interface/continue_cancel_button", f: %>
+  <%= f.govuk_submit disabled: !can_update_verify_qualification_request do %>
+    <%= render "shared/assessor_interface/cancel_link" %>
+  <% end %>
 <% end %>