Add teacher license form for Ghana #2379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
|
Review app deployed to https://apply-for-qts-review-2379-web.test.teacherservices.cloud/personas |
Hassanmir92
temporarily deployed
to
development
GitHub Actions
Inactive
Hassanmir92
temporarily deployed
to
development
GitHub Actions
Inactive
Hassanmir92
force-pushed
the
ghana-validation-number
branch
from
bdc3469 to
e669154
Compare
Hassanmir92
temporarily deployed
to
development
GitHub Actions
Inactive
This adds a form for capturing the registration number for Ghana which follows a very specific format.
We want a different title for Ghanian applicants.
We need a separate view as the interface will be different.
The Registration number, also known as the license number for Ghanaian specific applicants is a 3 part alphanumeric which has a specific format. To make it easier for applicants to not make mistakes when entering this number, we have decided to change the UI with additional validations in place to guide users. Note: As part of this work a new grouped input had to be introduced with inspiration taken from the GOV design systems date field. Since, this is a custom group of inputs, there are no helpers available and as a result of this, custom input fields with GOV design system classes have been used to replicate the desired design.
…tion number status Based on new rules, if a Ghanaian applicant, submits their teacher license/registration number and it is not valid, the status should be "in_progress", meanwhile if it is empty, it should be "not_started". If it is valid then only then it will move to "completed"
Hassanmir92
force-pushed
the
ghana-validation-number
branch
from
e669154 to
5fbbaf3
Compare
Hassanmir92
temporarily deployed
to
development
GitHub Actions
Inactive
syed87
reviewed
Sep 5, 2024
config/locales/helpers.en.yml
Outdated
| teacher_interface_further_information_request_item_text_form: | ||
| response: Enter your response | ||
| teacher_interface_ghana_registration_number_form: | ||
| registration_number: "Enter your teacher license number" |
There was a problem hiding this comment.
I noticed that the brackets are used in this section. It might be more consistent to remove them in this section.
syed87
reviewed
Sep 5, 2024
|
|
||
| <% if @application_form.region.status_check_online? %> | ||
| <% if @application_form.region.status_information.present? %> | ||
| <%= raw GovukMarkdown.render(@application_form.region.status_information) %> |
There was a problem hiding this comment.
I know this code get's replaced later on but could we go through how status_information and sanction_information work and how they're used in the edit view and website in general.
There was a problem hiding this comment.
Of course. Lets maybe jump on a call and go through it?
Hassanmir92
temporarily deployed
to
development
GitHub Actions
Inactive
Hassanmir92
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Registration number, also known as the license number for Ghanaian specific applicants is a 3 part alphanumeric which has a specific format. To make it easier for applicants to not make mistakes when entering this number, we have decided to change the UI with additional validations in place to guide users.
Additionally, the application form status updater has also been updated with regards to the status of the registration form. If a Ghanaian applicant, submits their teacher license/registration number and it is not valid, the status should be "in_progress", meanwhile if it is empty, it should be "not_started". If it is valid then only then it will move to "completed"
Important Design Note:
As part of this work a new grouped input had to be introduced with inspiration taken from the GOV design systems date field. Since, this is a custom group of inputs, there are no helpers available and as a result of this, custom input fields with GOV design system classes have been used to replicate the desired design.
Ghana Specific Form:
Ghana Specific Form with Errors:
Other:
