[AQTS-955] Adding new failure reason for ESOL expired #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://apply-for-qts-review-2746-web.test.teacherservices.cloud/personas |
… applications using ESOL to prove ELP
… applications using SELT to prove ELP
…l have english_language_selt_expired_during_assessment as an FI option. This is because we are not doing any migration on existing applications to remove this for SELT applications so this is to let the assessors know to just simply not use it. There is also no risk in assessors using it as it simply just sends the FI to the applicant.
Hassanmir92
force-pushed
the
AQTS-955-dev-add-new-expired-fi-reason-for-esol-elp-spoke
branch
from
96d0872 to
f794671
Compare
Hassanmir92
deleted the
AQTS-955-dev-add-new-expired-fi-reason-for-esol-elp-spoke
branch
|
Review app for PR 2746 was deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://dfedigital.atlassian.net/browse/AQTS-955
Post release action
Given that there are a few applications from the relevant country and with ESOL selected, we need to add this new reason to those existing submissions after we release the feature.
This can be done by running:
SyncAssessmentChecksAndFailureReasonsJob.perform_later(assessment)for each of those application assessments.It's important to note that we're only doing this to applications that have not yet started their assessment (which happens to be the case for all the applications with ESOL since it's a newly released feature)