Skip to content

[AQTS-955] Adding new failure reason for ESOL expired #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2025
Merged

[AQTS-955] Adding new failure reason for ESOL expired #2746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d17c36
Adding new failure reason for ESOL expired
Hassanmir92 May 7, 2025
83677b8
Adding new ESOL expired reason to assessments ELP factory
Hassanmir92 May 7, 2025
7e3279f
Remove english_language_esol_expired_during_assessment FI reason from…
Hassanmir92 Jun 6, 2025
53df92a
Remove english_language_selt_expired_during_assessment FI reason from…
Hassanmir92 Jun 6, 2025
f794671
Update assessor content for existing applications submitted that stil…
Hassanmir92 Jun 6, 2025
fb968b2
Fix test
Hassanmir92 Jun 6, 2025
306b426
Fix content
Hassanmir92 Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/lib/assessment_factories/english_language_proficiency_section.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def failure_reasons
[
FailureReasons::EL_REQUIRE_ALTERNATIVE,
FailureReasons::EL_ESOL_DOCUMENT_ILLEGIBLE,
FailureReasons::EL_ESOL_EXPIRED_DURING_ASSESSMENT,
FailureReasons::EL_ESOL_EXPIRED,
FailureReasons::EL_QUALIFICATION_INVALID,
FailureReasons::EL_ESOL_BELOW_REQUIRED_LEVEL,
]
Expand All @@ -47,7 +47,6 @@ def failure_reasons
),
FailureReasons::EL_GRADE_BELOW_B2,
FailureReasons::EL_SELT_EXPIRED,
FailureReasons::EL_SELT_EXPIRED_DURING_ASSESSMENT,
FailureReasons::EL_REQUIRE_ALTERNATIVE,
]
end
Expand Down
1 change: 1 addition & 0 deletions app/lib/failure_reasons.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class FailureReasons
EL_GRADE_BELOW_B2 = "english_language_not_achieved_b2",
EL_MOI_NOT_TAUGHT_IN_ENGLISH = "english_language_moi_not_taught_in_english",
EL_QUALIFICATION_INVALID = "english_language_qualification_invalid",
EL_ESOL_EXPIRED = "english_language_esol_expired",
EL_SELT_EXPIRED = "english_language_selt_expired",
FRAUD = "fraud",
FULL_PROFESSIONAL_STATUS = "full_professional_status",
Expand Down
3 changes: 2 additions & 1 deletion config/locales/assessor_interface.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,9 @@ en:
english_language_proficiency_document_illegible: There’s a problem with the English language proficiency test document, for example, it’s incorrect, illegible, or incomplete.
english_language_proficiency_require_alternative: The applicant needs to provide an MOI to verify their English language proficiency.
english_language_qualification_invalid: The applicant’s English language qualification is not from one of the approved providers.
english_language_esol_expired: The applicant provided evidence of an ESOL but it was not completed within the last 2 years.
english_language_selt_expired: The applicant provided evidence of a SELT but the test was not completed within the last 2 years.
english_language_selt_expired_during_assessment: The SELT evidence expired whilst the applicant waited for initial assessment.
english_language_selt_expired_during_assessment: "[DO NOT USE] The SELT evidence expired whilst the applicant waited for initial assessment."
english_language_unverifiable_reference_number: There’s a problem with the reference number, for example, it’s incorrect and can’t be verified.
fraud: Applicant has provided information that cannot be verified and is potentially fraudulent.
full_professional_status: Recognition level as a teacher does not match the required level, or has outstanding additional conditions.
Expand Down
1 change: 1 addition & 0 deletions config/locales/teacher_interface.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ en:
english_language_proficiency_document_illegible: There’s a problem with your English language proficiency test document.
english_language_proficiency_require_alternative: You need to provide another way to verify your English language proficiency.
english_language_qualification_invalid: Your English language qualification is not from one of the approved providers.
english_language_esol_expired: You have provided evidence of an English for Speakers of Other Languages (ESOL) certificate but it was not completed within the last 2 years.
english_language_selt_expired: You have provided evidence of a secure English language test (SELT) but the test was not completed within the last 2 years.
english_language_selt_expired_during_assessment: You have provided evidence of a secure English language test (SELT) but the test was completed more than 2 years ago.
english_language_unverifiable_reference_number: We were unable to verify the reference number you have provided.
Expand Down
1 change: 0 additions & 1 deletion spec/jobs/sync_assessment_checks_and_failure_reasons_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@
english_language_unverifiable_reference_number
english_language_not_achieved_b2
english_language_selt_expired
english_language_selt_expired_during_assessment
english_language_proficiency_require_alternative
],
)
Expand Down
4 changes: 1 addition & 3 deletions spec/lib/assessment_factory_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@
english_language_unverifiable_reference_number
english_language_not_achieved_b2
english_language_selt_expired
english_language_selt_expired_during_assessment
english_language_proficiency_require_alternative
suitability
suitability_previously_declined
Expand All @@ -421,7 +420,6 @@
english_language_proficiency_document_illegible
english_language_not_achieved_b2
english_language_selt_expired
english_language_selt_expired_during_assessment
english_language_proficiency_require_alternative
suitability
suitability_previously_declined
Expand All @@ -444,7 +442,7 @@
%w[
english_language_proficiency_require_alternative
english_language_esol_document_illegible
english_language_esol_expired_during_assessment
english_language_esol_expired
english_language_qualification_invalid
english_language_esol_below_required_level
suitability
Expand Down
Loading