AQTS 1041 update fi emails #2839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://apply-for-qts-review-2839-web.test.teacherservices.cloud/personas |
syed87
force-pushed
the
AQTS-1041-update-fi-emails
branch
from
123d591 to
234f841
Compare
Hassanmir92
requested changes
Aug 14, 2025
|
|
||
| You need to sign in to your application to submit the information. | ||
|
|
||
| This is your final opportunity to provide the required information. You must submit it by 11:59pm <%= @further_information_request.expires_at.in_time_zone('Europe/London').strftime('%Z') %> on <%= @further_information_request.expires_at.to_date.to_fs %> or your application will be declined. |
There was a problem hiding this comment.
I don't think the "This is your final opportunity" part is correct here? I don't see any logic on this being the third FI or not?
|
|
||
| This is your final opportunity to provide the required information. You must submit it by 11:59pm <%= @further_information_request.expires_at.in_time_zone('Europe/London').strftime('%Z') %> on <%= @further_information_request.expires_at.to_date.to_fs %> or your application will be declined. | ||
|
|
||
| ## Signing in to your application |
There was a problem hiding this comment.
This needs to still be inside the feature flag logic
Hassanmir92
reviewed
Aug 14, 2025
|
|
||
| You need to sign in to your application to submit the information. | ||
|
|
||
| You must submit this information by 11:59pm <%= @further_information_request.expires_at.in_time_zone('Europe/London').strftime('%Z') %> on <%= @further_information_request.expires_at.to_date.to_fs %> or your application will be declined. |
There was a problem hiding this comment.
You need some logic here for the "final request" as well
syed87
force-pushed
the
AQTS-1041-update-fi-emails
branch
from
234f841 to
779a421
Compare
Hassanmir92
approved these changes
Aug 14, 2025
syed87
force-pushed
the
AQTS-1041-update-fi-emails
branch
from
c01adb6 to
8b4c097
Compare
|
Review app for PR 2839 was deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dfedigital.atlassian.net/jira/software/projects/AQTS/boards/207?jql=assignee%20%3D%205e8313e39126d30c24f0ec5a&selectedIssue=AQTS-1041