Reorder staff list #2884
Open
Reorder staff list #2884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hassanmir92
reviewed
Sep 11, 2025
| @@ -9,28 +9,52 @@ | |||
| end | |||
|
|
|||
| let(:application_form) { create :application_form, :submitted } | |||
| let(:signed_in_staff) { create(:staff, :with_assess_permission) } | |||
There was a problem hiding this comment.
Might be better to either have the signed in user not have assess permission so that it doesn't appear in your tests or give a name to it so you don't have to force a "sort" on your expectation.
| @@ -74,7 +74,7 @@ class Staff < ApplicationRecord | |||
|
|
|||
| validates :name, presence: true | |||
|
|
|||
| scope :assessors, -> { where(assess_permission: true) } | |||
| scope :assessors, -> { where(assess_permission: true).order(:name) } | |||
There was a problem hiding this comment.
If this scope is not used anywhere else then I would rename this scope to be assessors_by_name so it's clear. Or if this scope is used anywhere else then to create a different scope with the name above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dfedigital.atlassian.net/browse/AQTS-1131
This pr reorder the list of assessors and reviewers for assignments
