-
Notifications
You must be signed in to change notification settings - Fork 1
[AQTS-1165] Public email domain blocking on application forms #2886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hassanmir92
wants to merge
13
commits into
main
Choose a base branch
from
AQTS-1165-dev-public-email-domain-blocking-application
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[AQTS-1165] Public email domain blocking on application forms #2886
Hassanmir92
wants to merge
13
commits into
main
from
AQTS-1165-dev-public-email-domain-blocking-application
+802
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9091882
to
4167bcd
Compare
Base automatically changed from
AQTS-1164-dev-public-email-domain-blocking-eligibility-checker
to
main
September 16, 2025 11:56
…ith_private_email_for_referee on application_forms table The purpose of started_with_private_email_for_referee is to differentiate between applications that began before and after the release of the feature. I see this column as a temporary column primarily used for certain features targetted to existing draft applications after the release which should automatically become irrelevant within 6 months. The purpose of requires_private_email_for_referee is to ensure the system is aware which applications are submit to the new rules
…ail_for_referee are set when a new application is starting
…o the new email domains All relevant content are hidden behind a feature flag
…form related to the new email domains All relevant content are hidden behind a feature flag
…isting and new) when entering public email domains in the work history spoke
…perience in England" and the applicant goes into the correct referee form when update is needed
f9cf0d8
to
3827546
Compare
…nge of requirements for references
3827546
to
aa36c81
Compare
…eferences form when referee email is invalid due to the domain being public
Review app deployed to https://apply-for-qts-review-2886-web.test.teacherservices.cloud/personas |
…Other England work experience
syed87
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://dfedigital.atlassian.net/browse/AQTS-1165
Introducing a new validation on a work history reference email to prevent any emails that has a domain we consider "public" being submitted as new applications through:
EmailDomain
class which holds information around which domains are public.