Skip to content

Conversation

Hassanmir92
Copy link
Collaborator

@Hassanmir92 Hassanmir92 commented Sep 15, 2025

Ticket: https://dfedigital.atlassian.net/browse/AQTS-1165

Introducing a new validation on a work history reference email to prevent any emails that has a domain we consider "public" being submitted as new applications through:

  1. Introducing a new EmailDomain class which holds information around which domains are public.
  2. Introducing content in relevant pages (hidden behind feature flag) to surface the new requirements to applicants.
  3. Updating the form logic for work history and other England work history contact pages to validate that the emails use a private domain (only enabled when feature flag is enabled).
  4. Introducing a new status on application sections "Update needed" to bring attention to existing application forms that have already completed their work history information but have not yet submitted. Once they attempt to submit, their application will move the work history spoke to this new status and by clicking on the work history or Other England work history spoke that has this status, it will take them to the relevant referee form. This new status will only be assigned if the work history has been completed but the email entered has a public email domain.
  5. Introducing a new banner for existing applications to notify them of new requirements for reference emails within draft view.

@Hassanmir92 Hassanmir92 self-assigned this Sep 15, 2025
@Hassanmir92 Hassanmir92 changed the base branch from main to AQTS-1164-dev-public-email-domain-blocking-eligibility-checker September 15, 2025 10:59
@Hassanmir92 Hassanmir92 force-pushed the AQTS-1165-dev-public-email-domain-blocking-application branch from 9091882 to 4167bcd Compare September 15, 2025 14:28
@Hassanmir92 Hassanmir92 changed the title [AQTS-1165] Publix email domain blocking on application forms [AQTS-1165] Public email domain blocking on application forms Sep 16, 2025
Base automatically changed from AQTS-1164-dev-public-email-domain-blocking-eligibility-checker to main September 16, 2025 11:56
…ith_private_email_for_referee on application_forms table

The purpose of started_with_private_email_for_referee is to differentiate between applications that began before and after the release of the feature. I see this column as a temporary column primarily used for certain features targetted to existing draft applications after the release which should automatically become irrelevant within 6 months.

The purpose of requires_private_email_for_referee is to ensure the system is aware which applications are submit to the new rules
…ail_for_referee are set when a new application is starting
…o the new email domains

All relevant content are hidden behind a feature flag
…form related to the new email domains

All relevant content are hidden behind a feature flag
…isting and new) when entering public email domains in the work history spoke
…perience in England" and the applicant goes into the correct referee form when update is needed
@Hassanmir92 Hassanmir92 force-pushed the AQTS-1165-dev-public-email-domain-blocking-application branch from f9cf0d8 to 3827546 Compare September 16, 2025 12:48
@Hassanmir92 Hassanmir92 force-pushed the AQTS-1165-dev-public-email-domain-blocking-application branch from 3827546 to aa36c81 Compare September 16, 2025 14:46
…eferences form when referee email is invalid due to the domain being public
@Hassanmir92 Hassanmir92 marked this pull request as ready for review September 16, 2025 14:59
@Hassanmir92 Hassanmir92 requested a review from a team as a code owner September 16, 2025 14:59
Copy link

Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants