Return a different error code for deactivated records #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunndabad
force-pushed
the
gone-deactivated
branch
from
9ef1811 to
161bd5f
Compare
gunndabad
force-pushed
the
gone-deactivated
branch
from
161bd5f to
da546e4
Compare
MrKevJoy
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
GET /v3/persons/<trn>endpoint, there's currently there's no way to know the difference between an invalid TRN and a deactivated record; we return a404and a 'Person does not exist' error in both cases.This change returns a different error code -
10058- for deactivated records. In future we should roll this out across all endpoints.