Skip to content

Fix bug in Dfs0 read time slice #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Fix bug in Dfs0 read time slice #808

merged 2 commits into from
Mar 25, 2025

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Mar 25, 2025 •
edited
Loading

image

@ecomodeller ecomodeller changed the title Figx bug in Dfs0 read time slice Fix bug in Dfs0 read time slice Mar 25, 2025
@ecomodeller ecomodeller marked this pull request as ready for review March 25, 2025 13:00
jsmariegaard
jsmariegaard approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ecomodeller! Looks great.

Makes sense to deprecate old way of slicing!

@ecomodeller ecomodeller merged commit ef596d9 into main Mar 25, 2025
9 checks passed
@ecomodeller ecomodeller deleted the bug/dfs0_read_time_slice branch March 25, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmariegaard jsmariegaard jsmariegaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecomodeller @jsmariegaard