Change dfs datatype #830
Merged
Change dfs datatype #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecomodeller
reviewed
May 23, 2025
mikeio/generic.py
Outdated
| n_time_steps = dfs_in.FileInfo.TimeAxis.NumberOfTimeSteps | ||
| deletevalue = dfs_in.FileInfo.DeleteValueFloat | ||
|
|
||
| # Write data to outputfile with new datatype |
There was a problem hiding this comment.
This can done in a simpler way, take a look at this example from mikecore: https://github.com/DHI/mikecore-python/blob/6ebbb1a1abebb88cd2060346611fa628eac57a82/tests/examples_misc.py#L59-L63
There was a problem hiding this comment.
good, yes i had the feeling it could be simplified
ecomodeller
reviewed
May 23, 2025
tests/test_generic.py
Outdated
| assert np.allclose(org, new, rtol=1e-08, atol=1e-10, equal_nan=True) | ||
|
|
||
|
|
||
| def test_change_datatype_dfsu(tmp_path: Path) -> None: |
There was a problem hiding this comment.
I don't think it is a good idea to change the data type on dfsu, Mike Zero will refuse to open it. It is good enough with a test for dfs0.
ecomodeller
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generic function + test to change the datatype of a DFS:s file