Skip to content

Conversation

ryan-kipawa
Copy link
Collaborator

Trying to residual plot on a comparer with more than one model currently fails. This PR adds a test for that and a fix. The test is also relevant for other plot functions that return multiple ax objects.

Hoping to merge this as a precursor to #456 🙃

@ecomodeller
Copy link
Member

Works as expected.

...
cc = ms.match(obs=[o1, o2, o3], mod=[mr1, mr2])
cc[0].plot.residual_hist();

image

cc[0].sel(model="SW_2").plot.residual_hist();

image

@ryan-kipawa ryan-kipawa merged commit 22f0fca into main Oct 25, 2024
6 checks passed
@ryan-kipawa ryan-kipawa deleted the feature/multiple_model_support_for_residual_hist_on_comparer branch October 25, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants