Skip to content

Add missing ruff lint default rules #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Add missing ruff lint default rules #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5133e32
Add missing ruff lint default rules
ecomodeller Jan 3, 2025
b24ee24
ruff format
jsmariegaard Jan 7, 2025
d4728f6
format TOML with "Even better TOML"
jsmariegaard Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modelskill/comparison/_comparer_plotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ def scatter(
skill_table: Optional[Union[str, List[str], bool]] = None,
ax: Optional[matplotlib.axes.Axes] = None,
**kwargs,
) -> matplotlib.axes.Axes | list[matplotlib.axes.Axes]:
) -> matplotlib.axes.Axes | list[matplotlib.axes.Axes]:
"""Scatter plot tailored for model-observation comparison.

Optionally, with density histogram.
Expand Down
59 changes: 25 additions & 34 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ exclude = ["notebooks", "tests"]
allow-direct-references = true

[project]
name="modelskill"
version="1.2.dev0"
name = "modelskill"
version = "1.2.dev0"
dependencies = [
"numpy > 1.24.4",
"pandas >= 1.4",
Expand All @@ -23,11 +23,11 @@ dependencies = [
]

authors = [
{ name="Jesper Sandvig Mariegaard", email="jem@dhigroup.com" },
{ name="Henrik Andersson", email="jan@dhigroup.com" },
{ name = "Jesper Sandvig Mariegaard", email = "jem@dhigroup.com" },
{ name = "Henrik Andersson", email = "jan@dhigroup.com" },
]
description="Compare results from simulations with observations."
license="MIT"
description = "Compare results from simulations with observations."
license = "MIT"
readme = "README.md"
requires-python = ">=3.10"
classifiers = [
Expand All @@ -44,45 +44,36 @@ classifiers = [
]

[project.optional-dependencies]
docs = ["quarto-cli==1.5.57",
"quartodoc==0.9.1",
"netCDF4",
"plotly >= 4.5",
"dask",
]
docs = [
"quarto-cli==1.5.57",
"quartodoc==0.9.1",
"netCDF4",
"plotly >= 4.5",
"dask",
]

dev = ["pytest",
"plotly >= 4.5",
"ruff==0.6.2",]
dev = ["pytest", "plotly >= 4.5", "ruff==0.6.2"]

test = [
"pytest",
"pytest-cov",
"openpyxl",
"dask",
"mypy",
"types-PyYAML",
"geopandas",
]
test = [
"pytest",
"pytest-cov",
"openpyxl",
"dask",
"mypy",
"types-PyYAML",
"geopandas",
]

notebooks = [
"nbformat",
"nbconvert",
"jupyter",
"plotly",
"shapely",
"seaborn",
]
notebooks = ["nbformat", "nbconvert", "jupyter", "plotly", "shapely", "seaborn"]

[project.urls]
"Homepage" = "https://github.com/DHI/modelskill"
"Bug Tracker" = "https://github.com/DHI/modelskill/issues"



[tool.ruff.lint]
ignore = ["E501"]
select = ["D200", "D205"]
select = ["E4", "E7", "E9", "F", "D200", "D205"]

[tool.mypy]
python_version = "3.9"
Expand Down
Loading