Skip to content

Only call extract on model result types where it makes sense #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

Only call extract on model result types where it makes sense #520

merged 4 commits into from
Jun 12, 2025

Conversation

ecomodeller
Copy link
Member

If adding type hints is challenging, the design is flawed🙄

@ecomodeller ecomodeller changed the title Spatialfield Only call extract on model result types where it makes sense Jun 11, 2025
@ecomodeller ecomodeller marked this pull request as ready for review June 11, 2025 19:10
@ecomodeller
Copy link
Member Author

ecomodeller commented Jun 12, 2025 •
edited
Loading

@jsmariegaard FYI adding more model types (e.g. vertical profile or network) will require rethinking the raw_mod_data data structure, which only makes sense for point model data, but is used for both track and point model results currently.

@ecomodeller ecomodeller merged commit 8f2f2c8 into main Jun 12, 2025
6 checks passed
@ecomodeller ecomodeller deleted the spatialfield branch June 12, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ecomodeller