Merge instead of + for combining comparers and collections, remove concatenation in time.
#521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecomodeller
changed the title
ecomodeller
changed the title
ecomodeller
changed the title
+ for combining comparers and collections.
ecomodeller
changed the title
+ for combining comparers and collections.+ for combining comparers and collections, remove concatenation in time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to:
Merge
mikeio.Dataset.mergepandas.DataFrame.mergexarray.Dataset.mergeConcat
Concat is a top-level function in pandas and Xarray (and a static method on Dataset in MIKEIO) that takes a list of objects to concatenate. If concatenation in time should be part of ModelSkill it makes sense if it behaves in a similar fashion.
xarray.concatpandas.concatmikeio.Dataset.concatUpdate: remove concatenation from ModelSkill, better to concatenate the model results using above libraries.