Skip to content

Porting wallet from the dig-sdk v1 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 24, 2025
Merged

Porting wallet from the dig-sdk v1 #4

merged 10 commits into from
Jun 24, 2025

Conversation

gogeterobert
Copy link
Collaborator

  • Added a wallet that has a state
  • Added a walletservice that is stateless and can be used to perform "CRUD" operations for the wallet object
  • Extracted utilities into separate services

@gogeterobert
Added wallet, wallet service and needed utilities for them to work
b493a5e 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@gogeterobert
Moved worker tests to match the same folder structure as in src
3d77ea6 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@gogeterobert
Added test for the encription service
c3ed357 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@gogeterobert
Added tests for the file cache service
2485305 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@gogeterobert
Added tests integration tests for the wallet service
a7913ad 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
93.08% (+5.78% 🔼)
 296/318
🟡 Branches
77.5% (+1.94% 🔼)
 62/80
🟢 Functions
90.41% (+14.41% 🔼)
 66/73
🟢 Lines
93.4% (+5.57% 🔼)
 283/303
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / WalletService.ts
 90% 66.67% 88.89% 89.74%
🟢
... / NconfService.ts
 100% 72.73% 100% 100%
🟢
... / EncryptionService.ts
 100% 100% 100% 100%
🟢
... / Wallet.ts
 98.51% 92.31% 100% 98.48%
🟢
... / FileCacheService.ts
 96% 80% 100% 96%

Test suite run success

40 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 833b41f

@gogeterobert
Cleaned up integration tests for the wallet
be6ff71 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@gogeterobert
Added tests to check the values returned by the methods in wallet
b4dec0c 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@gogeterobert
Added tests for the iscoinspendable method
a5430ca 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
MichaelTaylor3D
MichaelTaylor3D reviewed Jun 20, 2025
View reviewed changes
@gogeterobert
Added unit test for the wallet to check selectUnspentCoins
0a66d68 
Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@gogeterobert
Added a test that will fail in one year for the calculateFeeForCoinSp…
833b41f 
…ends to force revisiting this in the future as there is no proper way to do that right now

Signed-off-by: Robert Gogete <gogeterobert@yahoo.com>
@gogeterobert gogeterobert merged commit d514c2a into main Jun 24, 2025
3 checks passed
@gogeterobert gogeterobert deleted the wallet-86c40ay1k branch June 24, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelTaylor3D MichaelTaylor3D MichaelTaylor3D left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gogeterobert @MichaelTaylor3D