Fix clippy warnings and WiX installer issues

- Fix WiX installer XML structure by moving Publish elements inside UI element
- Auto-fix clippy warnings with cargo clippy --fix
- Resolve redundant closures, pattern matching, and other clippy issues
- Fix thread_local initialization and other compilation warnings
- Ensure CI formatting and clippy checks pass

Author: MichaelTaylor3D

src/cli/commands/add.rs

@@ -1,15 +1,13 @@
 //! Add command implementation
 
 use crate::cli::commands::find_repository_root;
-use crate::ignore::scanner::{FilteredFileScanner, ScanPhase};
+use crate::ignore::scanner::FilteredFileScanner;
 use crate::storage::parallel_processor::add_all_parallel;
 use crate::storage::store::Store;
 use anyhow::Result;
 use colored::Colorize;
 use indicatif::{MultiProgress, ProgressBar, ProgressStyle};
 use std::path::PathBuf;
-use std::sync::atomic::{AtomicUsize, Ordering};
-use std::sync::Arc;
 
 /// Execute the add command
 pub fn execute(

src/cli/commands/commit.rs

@@ -113,7 +113,7 @@ fn edit_commit_message(initial_message: &str) -> Result<String> {
     // Create temporary file with initial message
     let mut temp_file = NamedTempFile::new()?;
     writeln!(temp_file, "{}", initial_message)?;
-    writeln!(temp_file, "")?;
+    writeln!(temp_file)?;
     writeln!(
         temp_file,
         "# Please enter the commit message for your changes."

src/cli/commands/config.rs

@@ -145,23 +145,21 @@ pub fn execute(
                 } else {
                     println!("{}", value_str);
                 }
+            } else if json {
+                println!(
+                    "{}",
+                    serde_json::json!({
+                        "key": key_str,
+                        "value": null,
+                        "error": "not set"
+                    })
+                );
             } else {
-                if json {
-                    println!(
-                        "{}",
-                        serde_json::json!({
-                            "key": key_str,
-                            "value": null,
-                            "error": "not set"
-                        })
-                    );
-                } else {
-                    eprintln!(
-                        "{}",
-                        format!("Configuration key '{}' is not set", key_str).yellow()
-                    );
-                    return Err(anyhow::anyhow!("Configuration key not found"));
-                }
+                eprintln!(
+                    "{}",
+                    format!("Configuration key '{}' is not set", key_str).yellow()
+                );
+                return Err(anyhow::anyhow!("Configuration key not found"));
             }
         }
     } else {
@@ -204,24 +202,22 @@ fn list_configuration(config: &GlobalConfig, json: bool) -> Result<()> {
     if json {
         let config_map: std::collections::HashMap<String, String> = entries.into_iter().collect();
         println!("{}", serde_json::to_string_pretty(&config_map)?);
+    } else if entries.is_empty() {
+        println!("{}", "No configuration values set".yellow());
+        println!();
+        println!("{}", "To set configuration:".bold());
+        println!("  {}", "digstore config user.name \"Your Name\"".cyan());
+        println!(
+            "  {}",
+            "digstore config user.email \"your@email.com\"".cyan()
+        );
     } else {
-        if entries.is_empty() {
-            println!("{}", "No configuration values set".yellow());
-            println!();
-            println!("{}", "To set configuration:".bold());
-            println!("  {}", "digstore config user.name \"Your Name\"".cyan());
-            println!(
-                "  {}",
-                "digstore config user.email \"your@email.com\"".cyan()
-            );
-        } else {
-            println!("{}", "Global Configuration".green().bold());
-            println!("{}", "═".repeat(40));
-            println!();
+        println!("{}", "Global Configuration".green().bold());
+        println!("{}", "═".repeat(40));
+        println!();
 
-            for (key, value) in entries {
-                println!("{} = {}", key.bold(), value.cyan());
-            }
+        for (key, value) in entries {
+            println!("{} = {}", key.bold(), value.cyan());
         }
     }
 

src/cli/commands/decrypt.rs

@@ -1,9 +1,7 @@
 //! Decrypt command implementation
 
 use crate::cli::commands::find_repository_root;
-use crate::core::types::Hash;
 use crate::storage::store::Store;
-use crate::urn::{parse_urn, Urn};
 use anyhow::Result;
 use colored::Colorize;
 use std::io::Write;

src/cli/commands/get.rs

@@ -3,9 +3,8 @@
 use crate::cli::commands::find_repository_root;
 use crate::core::types::Hash;
 use crate::storage::store::Store;
-use crate::urn::{parse_urn, Urn};
+use crate::urn::parse_urn;
 use anyhow::Result;
-use base64;
 use colored::Colorize;
 use sha2::{Digest, Sha256};
 use std::io::Write;
@@ -75,7 +74,7 @@ fn generate_deterministic_random_bytes(seed: &str, size: usize) -> Vec<u8> {
 
     while result.len() < size {
         let mut current_hasher = hasher.clone();
-        current_hasher.update(&counter.to_le_bytes());
+        current_hasher.update(counter.to_le_bytes());
         let hash = current_hasher.finalize();
 
         let bytes_needed = size - result.len();

src/cli/commands/keygen.rs

@@ -1,8 +1,7 @@
 //! Key generation command implementation
 
 use crate::cli::context::CliContext;
-use crate::config::GlobalConfig;
-use crate::crypto::{derive_key_from_urn, derive_storage_address, transform_urn, PublicKey};
+use crate::crypto::{derive_key_from_urn, derive_storage_address, transform_urn};
 use crate::wallet::WalletManager;
 use anyhow::Result;
 use colored::Colorize;
@@ -31,7 +30,7 @@ pub fn execute_with_profile(
     println!("{}", "Generating content key...".bright_blue());
 
     // Get wallet profile from CLI context if not provided
-    let effective_wallet_profile = wallet_profile.or_else(|| CliContext::get_wallet_profile());
+    let effective_wallet_profile = wallet_profile.or_else(CliContext::get_wallet_profile);
 
     // Get public key from specified wallet profile or active wallet
     let public_key =

src/cli/commands/layer/inspect.rs

@@ -2,7 +2,6 @@ use crate::storage::Store;
 use anyhow::Result;
 use clap::Args;
 use colored::Colorize;
-use serde_json::json;
 
 #[derive(Args)]
 pub struct InspectArgs {

src/cli/commands/layer/list.rs

@@ -81,13 +81,11 @@ pub fn execute(
         // Show current layer
         if let Some(current_root) = store.current_root() {
             analyze_specific_layer(&store, current_root, &args)?;
+        } else if args.json {
+            println!("{}", json!({"error": "No current layer found"}));
         } else {
-            if args.json {
-                println!("{}", json!({"error": "No current layer found"}));
-            } else {
-                println!("{}", "No current layer found".yellow());
-                println!("  {} Use 'digstore commit' to create a layer", "→".cyan());
-            }
+            println!("{}", "No current layer found".yellow());
+            println!("  {} Use 'digstore commit' to create a layer", "→".cyan());
         }
     }
 

src/cli/commands/proof/generate.rs

@@ -1,5 +1,5 @@
 use crate::core::error::DigstoreError;
-use crate::proofs::{Proof, ProofElement, ProofMetadata, ProofPosition, ProofTarget};
+use crate::proofs::{Proof, ProofPosition};
 use crate::storage::Store;
 use crate::urn::parse_urn;
 use anyhow::Result;
@@ -177,7 +177,7 @@ fn handle_urn_prove(args: &ProveArgs) -> Result<()> {
         let root_hash = urn.root_hash.unwrap_or_else(|| {
             store
                 .current_root()
-                .unwrap_or_else(|| crate::core::types::Hash::zero())
+                .unwrap_or_else(crate::core::types::Hash::zero)
         });
         Proof::new_layer_proof(&store, root_hash)?
     };
@@ -202,7 +202,7 @@ fn output_proof(proof: &Proof, args: &ProveArgs) -> Result<()> {
         "binary" => {
             // Serialize proof to binary format using bincode
             bincode::serialize(proof)
-                .map_err(|e| DigstoreError::Serialization(e))?
+                .map_err(DigstoreError::Serialization)?
                 .into_iter()
                 .map(|b| b as char)
                 .collect::<String>()

src/cli/commands/proof/generate_archive_size.rs

@@ -2,15 +2,13 @@
 
 use crate::cli::commands::find_repository_root;
 use crate::cli::context::CliContext;
-use crate::config::global_config::{ConfigKey, ConfigValue, GlobalConfig};
 use crate::core::digstore_file::DigstoreFile;
 use crate::core::types::Hash;
 use crate::proofs::size_proof::ArchiveSizeProof;
 use crate::storage::{dig_archive::get_archive_path, Store};
 use crate::wallet::WalletManager;
 use anyhow::Result;
 use colored::Colorize;
-use std::io::Write;
 use std::path::PathBuf;
 
 /// Execute the proof generate-archive-size command