[Shell][iOS] You can now control navigation bar separator by using Shell.NavBarHasShadow. (#650)

Author: Vetle444

CHANGELOG.md

@@ -1,3 +1,6 @@
+## [47.3.0] 
+- [Shell][iOS] You can now control navigation bar separator by using `Shell.NavBarHasShadow`.
+
 ## [47.2.0] 
 - [NavigationListItem] Removed default icon color and set chevron color.
 - [TabBar] Set different background color.

src/app/Components/ComponentsSamples/Alerting/AlertingSamples.xaml

@@ -14,7 +14,6 @@
 
         <dui:NavigationListItem Title="{x:Static localizedStrings:LocalizedStrings.SystemMessage}"
                                 Command="{helpers:NavigationCommand {x:Type systemMessages:SystemMessageSamples}}"
-                                HasTopDivider="True"
                                 HasBottomDivider="True"/>
 
         <dui:NavigationListItem Title="{x:Static localizedStrings:LocalizedStrings.Dialog}"

src/app/Playground/VetleSamples/VetlePage.xaml

@@ -11,6 +11,7 @@
                  x:Name="This"
                  HideSoftInputOnTapped="True"
                  Title="Hello"
+                 
                  >
 
 

src/library/DIPS.Mobile.UI/Components/Shell/Android/ShellRenderer.cs

@@ -37,7 +37,7 @@ internal class BadgeShellBottomNavViewAppearanceTracker : ShellBottomNavViewAppe
     public BadgeShellBottomNavViewAppearanceTracker(IShellContext shellContext, ShellItem shellItem) : base(shellContext, shellItem)
     {
     }
-
+    
     protected override void SetBackgroundColor(BottomNavigationView bottomView, Microsoft.Maui.Graphics.Color color)
     {
         base.SetBackgroundColor(bottomView, color);

src/library/DIPS.Mobile.UI/Components/Shell/Shell.cs

@@ -30,8 +30,12 @@ public Shell()
             SetTabBarBackgroundColor(this, Colors.GetColor(ColorName.color_background_default));
             SetTabBarTitleColor(this, Colors.GetColor(ColorName.color_text_action));
             SetTabBarUnselectedColor(this, Colors.GetColor(ColorName.color_icon_subtle));
-            
+
+#if __ANDROID__
             SetNavBarHasShadow(this, false);
+#elif __IOS__
+            SetNavBarHasShadow(this, true);            
+#endif
         }
 
         private async void OnNavigated(object? sender, ShellNavigatedEventArgs e)

src/library/DIPS.Mobile.UI/Components/Shell/iOS/ShellRenderer.cs

@@ -32,6 +32,8 @@ protected override IShellNavBarAppearanceTracker CreateNavBarAppearanceTracker()
 
 public class NavBarAppearanceTracker : IShellNavBarAppearanceTracker
 {
+    private bool m_nextPageHasShadow;
+
     public void Dispose()
     {
 
@@ -73,8 +75,8 @@ public void SetAppearance(UINavigationController controller, ShellAppearance app
             navigationBarAppearance.BackgroundColor = background.ToPlatform();
 
         // Clear divider line
-        // TODO: Only hide this if we can manage to hide it in modal pages as well.
-        /*navigationBarAppearance.ShadowColor = UIColor.Clear;*/
+        if(!m_nextPageHasShadow)
+            navigationBarAppearance.ShadowColor = UIColor.Clear;
 
         // Set TitleColor
         var titleColor = appearance.TitleColor;
@@ -96,7 +98,7 @@ public void UpdateLayout(UINavigationController controller)
 
     public void SetHasShadow(UINavigationController controller, bool hasShadow)
     {
-        
+        m_nextPageHasShadow = hasShadow;
     }
 }