fix: increase HostName string length (cont) #8388
Conversation
|
Why not 253? (i.e. the limit in DNS) |
Prob a good idea. I fix this in minutes. |
fstagni
force-pushed
the
90_increase_hostname_64
branch
from
fe8454d to
33daa87
Compare
| ("DestinationHostName", "VARCHAR(50)"), | ||
| ("Source", "VARCHAR(50)"), | ||
| ("Destination", "VARCHAR(50)"), | ||
| ("SourceIP", "VARCHAR(39)"), |
There was a problem hiding this comment.
Why? Espeically with the comment about:
IPv6 address has up to 45 chars
There was a problem hiding this comment.
Funny, the google "LLM answer" gave 39 so that's what I used here. Now I am looking for more info, end for example in https://forum.djangoproject.com/t/length-of-ipv6-address-string/37953 they suggest as you do, but for example in https://stackoverflow.com/questions/166132/maximum-length-of-the-textual-representation-of-an-ipv6-address#:~:text=An%20IPv6%20address%20have%208,optional%20ending%20device%20name%20%25devname%20. the suggestion is 61 (and 64 few comments below)
There was a problem hiding this comment.
Given that we do not really have space issues I will now put 64 so to be on the safe side.
2 participants
This is completion of #8385