Implement staging buffer and use it for the material system #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VReaperV
added
T-Bug
T-Improvement
VReaperV
force-pushed
the
staging-buffer
branch
3 times, most recently
from
96d8c0d to
88c7d08
Compare
|
The CI error is caused by some unrelated bullshit. |
That sounds related |
Oh right, it's because of the moronic behaviour with static const in class declarations. |
|
Well no, it's gotta be caused by something else too, because even with |
Adds `GLStagingBuffer` and `GLBufferCopy()`. `GLStagingBuffer` allows setting buffer storage and map flags to 0 on the destination buffers, which pretty much guarantees that they will go into VRAM. The data is uploaded through mapping `stagingBuffer` and doing a copy of the data on the GPU.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Yeah I don't think |
Yeah, it's defaulting to C++14 apparently. |
|
It'll just have to do with the old redundant way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
GLStagingBufferandGLBufferCopy().GLStagingBufferallows setting buffer storage and map flags to 0 on the destination buffers, which pretty much guarantees that they will go into VRAM. The data is uploaded through mappingstagingBufferand doing a copy of the data on the GPU.The
stagingBufferitself should (still depends on the driver) go into the BAR memory (on Nvidia this shows up asDMA_CACHEDwhen usingr_glDebugProfile on; r_glDebugMode 7).Slightly improves material system performance. Currently this is used for all material system buffers except the portal one (since it requires reading from the GPU), and for the 2 geometry cache buffers that are currently used.
Also fixed
GLBuffer.mappedstate being retained on map change/load.