renderer: implement native sRGB support #1687
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illwieckz
force-pushed
the
illwieckz/srgb-native
branch
2 times, most recently
from
c914db4 to
ce0a6e3
Compare
|
Hmmm… I don't know where to write the line |
You only really need to call it once, it's global state and will affect all sRGB framebuffers. |
|
Which framebuffer should be sRGB there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement native sRGB support.
Obsoletes #1543:
It includes the commit from #1686:
This is based on an even older branch from 2019 as I initially tested native sRGB support before attempting to implement it in GLSL.
I rebased on current
masterand merged improvements from thesrgb-naivebranch as it implemented more corner cases than this one.It still suffers from the problems I faced in 2019: 2D colors are wrong. I need help on that part.