Open
Conversation
- Fix version regex to disallow leading zeros - Improve usability of Swagger UI by providing parameter and response examples - Avoid duplicating schema loading in test - Validate schema against known instance in test - Eliminate the need to pop $id during tests
This reverts commit dbc02ad.
8 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## prod #7829 +/- ##
==========================================
- Coverage 85.06% 85.01% -0.06%
==========================================
Files 157 157
Lines 23293 23374 +81
==========================================
+ Hits 19815 19872 +57
- Misses 3478 3502 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #7823
Checklist
Author
prodpromotions/yyyy-mm-dd-prodPromotion yyyy-mm-ddprodAuthor (reindex)
reindex:prodor the changes introduced by it will not require reindexing ofprodreindex:partialand its description documents the specific reindexing procedure forprodor requires a full reindex or is not labeledreindex:prodAuthor (mirror)
mirror:prodor the changes introduced by it will not require mirroring ofprodmirror:partialand its description documents the specific mirroring procedure forprodor requires a full mirroring or is not labeledmirror:prodAuthor (upgrading deployments)
upgradeor does not require upgrading deploymentsdeploy:sharedor does not modifydocker_images.json, and does not require deploying thesharedcomponent for any other reasondeploy:gitlabor does not require deploying thegitlabcomponentdeploy:runneror does not require deploying therunnerimageAuthor (before every review)
prodinto PR branch to integrate upstream changes)System administrator (after approval)
no sandboxN reviewslabel is accurateOperator
Operator (deploy
.sharedand.gitlabcomponents)_select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply_keep_unusedor this PR is not labeleddeploy:shared_select prod.gitlab && python scripts/create_gitlab_snapshot.py --no-restart(see operator manual for details) or this PR is not labeledbackup:gitlab_select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab applyor this PR is not labeleddeploy:gitlabdeploy:gitlabdeploy:gitlabSystem administrator (post-deploy of
.gitlabcomponent)prod.gitlabare complete or this PR is not labeleddeploy:gitlabOperator (deploy runner image)
_select prod.gitlab && make -C terraform/gitlab/runneror this PR is not labeleddeploy:runnerOperator (merge the branch)
ptagsOperator (main build)
prodprodprod_select prod.shared && make -C terraform/shared applyor this PR is not labeleddeploy:shared1 Promoted issues and PRs are referenced in the titles of the commits
that the promotion branch introduces to the stable branch. Prior to the
promotion, the status of promoted issues (PRs) is Lower (Merged lower).
Promoted PRs in status Done do not need to be moved.
Operator (reindex)
prodor this PR is neither labeledreindex:partialnorreindex:prodprodor this PR is neither labeledreindex:partialnorreindex:prodprodor this PR is neither labeledreindex:partialnorreindex:prodprodor this PR does not require reindexingprodprodor this PR does not require reindexingprodprodor this PR does not require reindexingprodprodor this PR does not require reindexingprodprodor this PR does not require reindexingproddeploy_browserjob in the GitLab pipeline for this PR inprodor this PR does not require reindexingprodOperator (mirroring)
prodor this PR is not labelledmirror:prodprodor this PR is not labelledmirror:prodprodor this PR is not labelledmirror:prodOperator
System administrator
Shorthand for review comments
Lline is too longWline wrapping is wrongQbad quotesFother formatting problem