Skip to content

Conversation

misteriaud
Copy link
Contributor

@misteriaud misteriaud commented Oct 15, 2025

What does this PR do?

This PR adds the option to include the security-agent when building a local Agent Docker image using the command
dda inv agent.hacky-dev-image-build by introducing the flag --security-agent.

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-runtimes labels Oct 15, 2025
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b3c11d5

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${674.44}$$ < $${702.15}$$ $${+0.04}$$ $${164.6}$$ < $${177.79}$$
agent_deb_amd64_fips $${0}$$ $${668.94}$$ < $${696.65}$$ $${-0}$$ $${163.78}$$ < $${176.53}$$
agent_heroku_amd64 $${0}$$ $${336.28}$$ < $${340.18}$$ $${-0}$$ $${89.77}$$ < $${91.08}$$
agent_msi $${0}$$ $${1012.54}$$ < $${1015.38}$$ $${0}$$ $${149.15}$$ < $${150.78}$$
agent_rpm_amd64 $${0}$$ $${674.43}$$ < $${702.14}$$ $${-0}$$ $${166.94}$$ < $${180.53}$$
agent_rpm_amd64_fips $${0}$$ $${668.93}$$ < $${696.64}$$ $${-0}$$ $${165.42}$$ < $${178.79}$$
agent_rpm_arm64 $${0}$$ $${663.97}$$ < $${686.31}$$ $${+0}$$ $${153.2}$$ < $${161.22}$$
agent_rpm_arm64_fips $${0}$$ $${659.49}$$ < $${681.84}$$ $${-0.09}$$ $${152.56}$$ < $${160.18}$$
agent_suse_amd64 $${0}$$ $${674.43}$$ < $${702.14}$$ $${-0}$$ $${166.94}$$ < $${180.53}$$
agent_suse_amd64_fips $${0}$$ $${668.93}$$ < $${696.64}$$ $${-0}$$ $${165.42}$$ < $${178.79}$$
agent_suse_arm64 $${0}$$ $${663.97}$$ < $${686.31}$$ $${+0}$$ $${153.2}$$ < $${161.22}$$
agent_suse_arm64_fips $${0}$$ $${659.49}$$ < $${681.84}$$ $${-0.09}$$ $${152.56}$$ < $${160.18}$$
docker_agent_amd64 $${+0}$$ $${745.87}$$ < $${773.59}$$ $${-0}$$ $${251.69}$$ < $${266.06}$$
docker_agent_arm64 $${-0}$$ $${759.36}$$ < $${781.7}$$ $${+0}$$ $${242.29}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${+0}$$ $${936.74}$$ < $${964.45}$$ $${-0}$$ $${320.31}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${+0}$$ $${938.82}$$ < $${961.17}$$ $${+0}$$ $${306.9}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${+0}$$ $${212.95}$$ < $${213.74}$$ $${-0}$$ $${72.25}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${-0}$$ $${228.92}$$ < $${229.68}$$ $${+0}$$ $${68.51}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.4}$$ < $${39.3}$$ $${-0}$$ $${14.83}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.13}$$ < $${37.94}$$ $${+0}$$ $${14.28}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${+0}$$ $${7.81}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.21}$$ < $${29.11}$$ $${+0}$$ $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.63}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${41.83}$$ < $${54.97}$$ $${+0}$$ $${10.88}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${39.65}$$ < $${51.9}$$ $${+0}$$ $${9.4}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${39.52}$$ < $${51.84}$$ $${-0}$$ $${9.48}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${41.83}$$ < $${54.97}$$ $${+0}$$ $${10.9}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${41.83}$$ < $${54.97}$$ $${+0}$$ $${10.9}$$ < $${14.47}$$

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6ee09171-7fec-42df-b7cc-d2937e3461e0

Baseline: b3c11d5
Comparison: db45fcd
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +13.30 [+11.53, +15.08] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +13.30 [+11.53, +15.08] 1 Logs
docker_containers_memory memory utilization +4.01 [+3.48, +4.55] 1 Logs
tcp_syslog_to_blackhole ingress throughput +2.29 [+2.22, +2.37] 1 Logs
quality_gate_logs % cpu utilization +1.36 [-1.46, +4.17] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization +0.64 [+0.51, +0.76] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.49 [+0.36, +0.61] 1 Logs
ddot_logs memory utilization +0.18 [+0.12, +0.25] 1 Logs
otlp_ingest_logs memory utilization +0.09 [-0.04, +0.22] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.58, +0.64] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.19, +0.23] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.60, +0.62] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.60, +0.60] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.05 [-0.66, +0.56] 1 Logs
quality_gate_idle memory utilization -0.07 [-0.11, -0.03] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization -0.10 [-0.26, +0.06] 1 Logs
quality_gate_idle_all_features memory utilization -0.22 [-0.27, -0.17] 1 Logs bounds checks dashboard
file_tree memory utilization -0.23 [-0.27, -0.19] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.26 [-0.45, -0.07] 1 Logs
ddot_metrics memory utilization -0.58 [-0.75, -0.41] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.70 [-0.74, -0.66] 1 Logs
quality_gate_metrics_logs memory utilization -1.24 [-1.45, -1.03] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 9/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@misteriaud misteriaud added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Oct 16, 2025
@misteriaud misteriaud marked this pull request as ready for review October 16, 2025 13:12
@misteriaud misteriaud requested a review from a team as a code owner October 16, 2025 13:13
@misteriaud misteriaud requested a review from pgimalac October 16, 2025 13:13
@misteriaud
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 16, 2025

View all feedbacks in Devflow UI.

2025-10-16 13:53:50 UTC ℹ️ Start processing command /merge


2025-10-16 13:53:56 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).


2025-10-16 14:07:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit bc704b7 into main Oct 16, 2025
270 of 272 checks passed
@dd-mergequeue dd-mergequeue bot deleted the misteriaud/adding_security_agent_to_hackydev branch October 16, 2025 14:07
@github-actions github-actions bot added this to the 7.73.0 milestone Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants