[AGENTRUN-782] Set disk and network v2 checks to default for windows and linux

[jeremy-hanna]

What does this PR do?

Enable the network and disk v2 checks by default for windows and linux so python runtime will only be needed for additional integrations.

We've tested this on internal clusters for the past couple weeks and everything looks good.

Motivation

Describe how you validated your changes

These have been running on internal clusters for weeks now.

Additional Notes

[OliviaShoup]

looks good! thanks for the PR :)

[dustmop]

Looks like the unit tests are failing because they rely on these values being false by default, see here and here.

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c3f5dee8-fbd5-472e-afd1-168494e778d6

Baseline: 8ca9b5c
Comparison: e89899a
Diff

Optimization Goals: ✅ Improvement(s) detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-5.09	[-5.28, -4.90]	1	Logs
✅	ddot_metrics_sum_cumulative	memory utilization	-6.10	[-6.22, -5.98]	1	Logs
✅	ddot_metrics	memory utilization	-7.19	[-7.37, -7.02]	1	Logs
✅	ddot_metrics_sum_delta	memory utilization	-7.44	[-7.61, -7.27]	1	Logs
✅	quality_gate_idle_all_features	memory utilization	-8.04	[-8.07, -8.00]	1	Logs bounds checks dashboard
✅	ddot_logs	memory utilization	-9.74	[-9.80, -9.68]	1	Logs
✅	docker_containers_memory	memory utilization	-9.77	[-10.20, -9.34]	1	Logs
✅	file_tree	memory utilization	-10.57	[-10.61, -10.52]	1	Logs
✅	quality_gate_metrics_logs	memory utilization	-11.86	[-12.06, -11.66]	1	Logs bounds checks dashboard
✅	otlp_ingest_metrics	memory utilization	-13.01	[-13.13, -12.88]	1	Logs
✅	otlp_ingest_logs	memory utilization	-14.22	[-14.35, -14.09]	1	Logs
✅	quality_gate_idle	memory utilization	-17.78	[-17.84, -17.73]	1	Logs bounds checks dashboard
✅	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-19.07	[-19.11, -19.03]	1	Logs

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
✅	docker_containers_cpu	% cpu utilization	-10.31	[-10.95, -9.66]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_to_blackhole_500ms_latency	egress throughput	+0.08	[-0.52, +0.69]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.03	[-0.57, +0.64]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.22, +0.26]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.62, +0.58]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.19	[-0.80, +0.43]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.67	[-0.74, -0.59]	1	Logs
➖	quality_gate_logs	% cpu utilization	-3.99	[-6.68, -1.30]	1	Logs bounds checks dashboard
✅	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-5.09	[-5.28, -4.90]	1	Logs
✅	ddot_metrics_sum_cumulative	memory utilization	-6.10	[-6.22, -5.98]	1	Logs
✅	ddot_metrics	memory utilization	-7.19	[-7.37, -7.02]	1	Logs
✅	ddot_metrics_sum_delta	memory utilization	-7.44	[-7.61, -7.27]	1	Logs
✅	quality_gate_idle_all_features	memory utilization	-8.04	[-8.07, -8.00]	1	Logs bounds checks dashboard
✅	ddot_logs	memory utilization	-9.74	[-9.80, -9.68]	1	Logs
✅	docker_containers_memory	memory utilization	-9.77	[-10.20, -9.34]	1	Logs
✅	docker_containers_cpu	% cpu utilization	-10.31	[-10.95, -9.66]	1	Logs
✅	file_tree	memory utilization	-10.57	[-10.61, -10.52]	1	Logs
✅	quality_gate_metrics_logs	memory utilization	-11.86	[-12.06, -11.66]	1	Logs bounds checks dashboard
✅	otlp_ingest_metrics	memory utilization	-13.01	[-13.13, -12.88]	1	Logs
✅	otlp_ingest_logs	memory utilization	-14.22	[-14.35, -14.09]	1	Logs
✅	quality_gate_idle	memory utilization	-17.78	[-17.84, -17.73]	1	Logs bounds checks dashboard
✅	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-19.07	[-19.11, -19.03]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor fb32a1e

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0.01}$$	$${674.79}$$ < $${702.15}$$	$${+0.03}$$	$${164.66}$$ < $${177.79}$$
✅	agent_deb_amd64_fips	$${+0.01}$$	$${669.3}$$ < $${696.65}$$	$${+0.02}$$	$${163.87}$$ < $${176.53}$$
✅	agent_heroku_amd64	$${+0.01}$$	$${336.55}$$ < $${340.18}$$	$${+0.01}$$	$${89.83}$$ < $${91.08}$$
✅	agent_msi	$${+0.02}$$	$${1013.6}$$ < $${1015.38}$$	$${+0.04}$$	$${148.45}$$ < $${150.78}$$
✅	agent_rpm_amd64	$${+0.01}$$	$${674.78}$$ < $${702.14}$$	$${-0.02}$$	$${166.96}$$ < $${180.53}$$
✅	agent_rpm_amd64_fips	$${+0.01}$$	$${669.29}$$ < $${696.64}$$	$${+0.05}$$	$${165.57}$$ < $${178.79}$$
✅	agent_rpm_arm64	$${-0}$$	$${664.36}$$ < $${686.31}$$	$${+0.03}$$	$${153.26}$$ < $${161.22}$$
✅	agent_rpm_arm64_fips	$${+0}$$	$${659.89}$$ < $${681.84}$$	$${+0.04}$$	$${152.71}$$ < $${160.18}$$
✅	agent_suse_amd64	$${+0.01}$$	$${674.78}$$ < $${702.14}$$	$${-0.02}$$	$${166.96}$$ < $${180.53}$$
✅	agent_suse_amd64_fips	$${+0.01}$$	$${669.29}$$ < $${696.64}$$	$${+0.05}$$	$${165.57}$$ < $${178.79}$$
✅	agent_suse_arm64	$${-0}$$	$${664.36}$$ < $${686.31}$$	$${+0.03}$$	$${153.26}$$ < $${161.22}$$
✅	agent_suse_arm64_fips	$${+0}$$	$${659.89}$$ < $${681.84}$$	$${+0.04}$$	$${152.71}$$ < $${160.18}$$
✅	docker_agent_amd64	$${+0.01}$$	$${746.22}$$ < $${773.59}$$	$${+0.01}$$	$${251.83}$$ < $${266.06}$$
✅	docker_agent_arm64	$${-0}$$	$${759.76}$$ < $${781.7}$$	$${+0.01}$$	$${242.44}$$ < $${251.85}$$
✅	docker_agent_jmx_amd64	$${+0.01}$$	$${937.08}$$ < $${964.45}$$	$${+0.02}$$	$${320.45}$$ < $${334.68}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${939.22}$$ < $${961.17}$$	$${-0.01}$$	$${307.03}$$ < $${316.44}$$
✅	docker_cluster_agent_amd64	$${+0.01}$$	$${213.02}$$ < $${213.74}$$	$${+0}$$	$${72.26}$$ < $${73.14}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${228.92}$$ < $${229.68}$$	$${+0}$$	$${68.53}$$ < $${69.41}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${+0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${+0}$$	$${38.44}$$ < $${39.3}$$	$${+0}$$	$${14.84}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${-0}$$	$${37.12}$$ < $${37.94}$$	$${-0}$$	$${14.28}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${+0.01}$$	$${29.66}$$ < $${30.53}$$	$${+0}$$	$${7.82}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${+0}$$	$${28.25}$$ < $${29.11}$$	$${+0}$$	$${6.77}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${+0.01}$$	$${29.66}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${+0.01}$$	$${29.66}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${+0}$$	$${41.89}$$ < $${54.97}$$	$${+0}$$	$${10.9}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${+0}$$	$${39.71}$$ < $${51.9}$$	$${+0}$$	$${9.41}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${+0}$$	$${39.58}$$ < $${51.84}$$	$${+0}$$	$${9.49}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${+0}$$	$${41.89}$$ < $${54.97}$$	$${-0}$$	$${10.91}$$ < $${14.47}$$
✅	iot_agent_suse_amd64	$${+0}$$	$${41.89}$$ < $${54.97}$$	$${-0}$$	$${10.91}$$ < $${14.47}$$

[louis-cqrl]

LGTM, left small comments, feel free to ignore them

[louis-cqrl]

we are in diskv2 folder, don't we want to set it to true ?

[pgimalac]

use_diskv2_check takes precedence over disk_check.use_core_loader in the code
Ie. if use_diskv2_check: true then we actually use the Go v2 check instead of the Python check, no matter the value of disk_check.use_core_loader
Which is quite counter intuitive though 😄

[louis-cqrl]

Thanks for the details 🙇🏻

[pgimalac]

I think your comment still reveals an issue, we're testing something which can't happen here: if use_diskv2_check is false then the v2 code is unreachable, so there is no point in checking (and testing) that here

I think we can just remove the test and the whole condition at the beginning of Configure in diskv2 (btw there is no equivalent in networkv2)

[jeremy-hanna]

this is testing that an error is thrown when trying to initialize the diskv2 check when it shouldn't be used. It maybe should just be deleted instead