Skip to content

upgrade goflow2 to fix netflow parser issue#49888

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
garrison.stauffer/goflow-upgrade
Apr 27, 2026
Merged

upgrade goflow2 to fix netflow parser issue#49888
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
garrison.stauffer/goflow-upgrade

Conversation

@garrison-stauffer
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR integrates the change from this PR netsampler/goflow2#503 to fix an issue we are seeing in some customer environments when parsing incoming packets.

Motivation

Addresses an issue reported by a customer

Describe how you validated your changes

  • Replayed packets from a pcap to validate that they are now parsed as expected

Additional Notes

@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Apr 24, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Apr 24, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 24, 2026

Go Package Import Differences

Baseline: c1888d8
Comparison: 66e9c4f

binaryosarchchange
agentlinuxamd64
+0, -1
-gopkg.in/yaml.v2
agentlinuxarm64
+0, -1
-gopkg.in/yaml.v2
agentdarwinamd64
+0, -1
-gopkg.in/yaml.v2
agentdarwinarm64
+0, -1
-gopkg.in/yaml.v2
agentaixppc64
+0, -1
-gopkg.in/yaml.v2
iot-agentlinuxamd64
+0, -1
-gopkg.in/yaml.v2
iot-agentlinuxarm64
+0, -1
-gopkg.in/yaml.v2
heroku-agentlinuxamd64
+0, -1
-gopkg.in/yaml.v2

@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 Bot commented Apr 24, 2026

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 50.20% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 66e9c4f | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 24, 2026

Files inventory check summary

File checks results against ancestor c1888d89:

Results for datadog-agent_7.80.0~devel.git.265.66e9c4f.pipeline.109967133-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Apr 24, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9d75223f-97ea-4ca1-9ce3-2eddb3ecd62b

Baseline: e083f5b
Comparison: 6d6e5fb
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -2.09 [-4.92, +0.74] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs memory utilization +0.51 [+0.39, +0.62] 1 Logs
docker_containers_memory memory utilization +0.47 [+0.37, +0.58] 1 Logs
quality_gate_idle memory utilization +0.43 [+0.38, +0.48] 1 Logs bounds checks dashboard
file_tree memory utilization +0.37 [+0.32, +0.41] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.21 [-0.03, +0.44] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.15 [-0.01, +0.30] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.07 [-0.49, +0.62] 1 Logs
quality_gate_logs % cpu utilization +0.06 [-0.91, +1.04] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_v3 ingress throughput +0.03 [-0.17, +0.22] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.38, +0.43] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.37, +0.42] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.11, +0.11] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.21, +0.20] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.18, +0.07] 1 Logs
ddot_logs memory utilization -0.08 [-0.15, -0.02] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.11 [-0.17, -0.06] 1 Logs
ddot_metrics memory utilization -0.14 [-0.33, +0.06] 1 Logs
quality_gate_metrics_logs memory utilization -0.26 [-0.51, -0.01] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization -0.45 [-0.65, -0.26] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.49 [-0.69, -0.29] 1 Logs
quality_gate_idle_all_features memory utilization -0.64 [-0.68, -0.60] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -1.11 [-1.26, -0.95] 1 Logs
docker_containers_cpu % cpu utilization -2.09 [-4.92, +0.74] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 682 ≥ 26
docker_containers_memory memory_usage 10/10 243.51MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 670 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.17GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 140.40MiB ≤ 147MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 464.34MiB ≤ 495MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 175.13MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 368.33 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 376.80MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@garrison-stauffer garrison-stauffer added the qa/done QA done before merge and regressions are covered by tests label Apr 24, 2026
@garrison-stauffer garrison-stauffer marked this pull request as ready for review April 24, 2026 19:41
@garrison-stauffer
Copy link
Copy Markdown
Contributor Author

/merge -m squash

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Apr 27, 2026

View all feedbacks in Devflow UI.

2026-04-27 17:23:59 UTC ℹ️ Start processing command /merge -m squash


2026-04-27 17:24:07 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-04-27 19:09:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-04-27 21:11:24 UTC 🚨 MergeQueue: This merge request is in error

error while getting head build completion result

Details

Error: There was an error while retrieving the result for pipeline 109996378

FullStacktrace:
child workflow execution error (type: mergequeue_private.MergeQueue_WaitForChecksOrUntilIsFinal, workflowID: wait_checks_4783636b025f0fe6a900338306913bd8323e39ee, runID: 019dd058-f64c-714c-aa0f-a6234f616a86, initiatedEventID: 1544, startedEventID: 1546): child workflow execution error (type: mergequeue.MergeQueue_WaitForCompletionOfRef, workflowID: 019dd058-f64c-714c-aa0f-a6234f616a86_8, runID: 019dd058-f6d6-730b-8e0f-643cfe7506ca, initiatedEventID: 8, startedEventID: 10): There was an error while retrieving the result for pipeline 109996378 (type: FlowError, retryable: false): There was an error while retrieving the result for pipeline 109996378

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 27, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor c1888d8
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +7.94 KiB (0.00% increase) 738.997 → 739.004 → 750.310
agent_deb_amd64_fips +7.94 KiB (0.00% increase) 697.423 → 697.431 → 702.690
agent_heroku_amd64 +7.91 KiB (0.00% increase) 309.103 → 309.111 → 313.960
agent_rpm_amd64 +7.94 KiB (0.00% increase) 738.980 → 738.988 → 750.280
agent_rpm_amd64_fips +7.94 KiB (0.00% increase) 697.407 → 697.415 → 702.670
agent_rpm_arm64 +7.88 KiB (0.00% increase) 717.073 → 717.081 → 724.050
agent_rpm_arm64_fips +7.94 KiB (0.00% increase) 678.532 → 678.539 → 684.460
agent_suse_amd64 +7.94 KiB (0.00% increase) 738.980 → 738.988 → 750.280
agent_suse_amd64_fips +7.94 KiB (0.00% increase) 697.407 → 697.415 → 702.670
agent_suse_arm64 +7.88 KiB (0.00% increase) 717.073 → 717.081 → 724.050
agent_suse_arm64_fips +7.94 KiB (0.00% increase) 678.532 → 678.539 → 684.460
docker_agent_amd64 +7.94 KiB (0.00% increase) 799.455 → 799.463 → 805.870
docker_agent_arm64 +7.88 KiB (0.00% increase) 802.357 → 802.364 → 809.730
docker_agent_jmx_amd64 +7.94 KiB (0.00% increase) 990.375 → 990.382 → 996.590
docker_agent_jmx_arm64 +7.89 KiB (0.00% increase) 982.055 → 982.063 → 989.410
iot_agent_deb_amd64 +7.94 KiB (0.02% increase) 44.372 → 44.380 → 44.970
iot_agent_deb_arm64 +7.91 KiB (0.02% increase) 41.361 → 41.368 → 42.560
iot_agent_deb_armhf +7.93 KiB (0.02% increase) 42.097 → 42.105 → 42.740
iot_agent_rpm_amd64 +7.94 KiB (0.02% increase) 44.373 → 44.381 → 44.970
iot_agent_suse_amd64 +7.94 KiB (0.02% increase) 44.373 → 44.381 → 44.970
10 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cluster_agent_amd64 206.269 MiB
docker_cluster_agent_arm64 220.383 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.347 MiB
docker_dogstatsd_arm64 37.565 MiB
dogstatsd_deb_amd64 30.001 MiB
dogstatsd_deb_arm64 28.142 MiB
dogstatsd_rpm_amd64 30.001 MiB
dogstatsd_suse_amd64 30.001 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -24.4 KiB (0.01% reduction) 174.984 → 174.960 → 179.160
agent_deb_amd64_fips +25.61 KiB (0.02% increase) 166.645 → 166.670 → 174.440
agent_heroku_amd64 -3.01 KiB (0.00% reduction) 74.911 → 74.908 → 80.310
agent_rpm_amd64 +42.93 KiB (0.02% increase) 176.944 → 176.986 → 182.080
agent_rpm_amd64_fips +10.86 KiB (0.01% increase) 168.007 → 168.017 → 174.140
agent_rpm_arm64 neutral 159.252 MiB → 163.610
agent_rpm_arm64_fips +9.27 KiB (0.01% increase) 151.449 → 151.458 → 156.850
agent_suse_amd64 +42.93 KiB (0.02% increase) 176.944 → 176.986 → 182.080
agent_suse_amd64_fips +10.86 KiB (0.01% increase) 168.007 → 168.017 → 174.140
agent_suse_arm64 neutral 159.252 MiB → 163.610
agent_suse_arm64_fips +9.27 KiB (0.01% increase) 151.449 → 151.458 → 156.850
docker_agent_amd64 +25.92 KiB (0.01% increase) 267.115 → 267.140 → 272.990
docker_agent_arm64 +18.18 KiB (0.01% increase) 254.142 → 254.160 → 261.470
docker_agent_jmx_amd64 +14.86 KiB (0.00% increase) 335.778 → 335.793 → 341.610
docker_agent_jmx_arm64 +9.93 KiB (0.00% increase) 318.782 → 318.791 → 326.050
docker_cluster_agent_amd64 neutral 72.298 MiB → 73.460
docker_cluster_agent_arm64 neutral 67.762 MiB → 68.680
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.229 MiB → 15.870
docker_dogstatsd_arm64 neutral 14.549 MiB → 14.890
dogstatsd_deb_amd64 neutral 7.935 MiB → 8.830
dogstatsd_deb_arm64 neutral 6.818 MiB → 7.750
dogstatsd_rpm_amd64 neutral 7.945 MiB → 8.840
dogstatsd_suse_amd64 neutral 7.945 MiB → 8.840
iot_agent_deb_amd64 +2.04 KiB (0.02% increase) 11.678 → 11.680 → 13.210
iot_agent_deb_arm64 +4.46 KiB (0.04% increase) 9.981 → 9.985 → 11.620
iot_agent_deb_armhf +2.07 KiB (0.02% increase) 10.186 → 10.188 → 11.780
iot_agent_rpm_amd64 neutral 11.697 MiB → 13.230
iot_agent_suse_amd64 neutral 11.697 MiB → 13.230

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 6d6e5fb into main Apr 27, 2026
223 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the garrison.stauffer/goflow-upgrade branch April 27, 2026 23:28
@github-actions github-actions Bot added this to the 7.80.0 milestone Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants