fix(vcr): fix middleware incompatability with request bodies that aren't utf-8 decodable (#233)

sabrenner · web-flow · commit bb2433e21492 · 2025-08-07T19:52:10.000-04:00
* fix &amp; rel note
diff --git a/ddapm_test_agent/agent.py b/ddapm_test_agent/agent.py
@@ -118,7 +118,7 @@ async def _vcr_proxy_cassette_prefix(request: Request) -> Optional[str]:
         request_body: dict[str, str] = await request.json()
         requested_test_name = request_body.get("test_name")
         return requested_test_name
-    except json.JSONDecodeError:
+    except (json.JSONDecodeError, UnicodeDecodeError):
         return None
 
 
diff --git a/releasenotes/notes/vcr-cassette-name-middleware-fix-9e47c395892a9fe7.yaml b/releasenotes/notes/vcr-cassette-name-middleware-fix-9e47c395892a9fe7.yaml
@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    vcr: fixes an issue where the vcr cassette name middleware would not properly ignore decoding errors for request bodies that were not associated with then ``/vcr/test/start`` path.

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +fixes:
 +  - |
 +    vcr: fixes an issue where the vcr cassette name middleware would not properly ignore decoding errors for request bodies that were not associated with then ``/vcr/test/start`` path.