More fixes for do-not-merge #7274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
area:builds
bouwkast
approved these changes
Jul 28, 2025
NachoEchevarria
approved these changes
Jul 29, 2025
andrewlock
removed
the
status:do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Try to make the do-not-merge action a required job
Reason for change
For some mystical reason, the do_not_merge job runs on PRs, but I can't mark it as required. AI thinks this change will work. We'll see...
Implementation details
Move the decision on pass/fail to a separate job
Test coverage
This is the test, but I might have to merge it to be sure