Skip to content

[BUG]: new baggage propagator default breaks existing tracing #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chadawagner opened this issue May 27, 2025 · 1 comment
Open

[BUG]: new baggage propagator default breaks existing tracing #3556

chadawagner opened this issue May 27, 2025 · 1 comment
Assignees
Labels
bug unintended behavior that has to be fixed

Comments

@chadawagner
Copy link

Tracer Version(s)

1.73.0,1.73.1

Go Version(s)

go version go1.23.1 darwin/arm64

Bug Report

The propagation styles default was previously "datadog,tracecontext" but was changed in v1.73.0 to "datadog,tracecontext,baggage".

As the chained propagator tries the configured options, if nothing is found for the first 2, and if any unrelated baggage headers are present in the incoming request (e.g. "Baggage: foo=bar"), it will somehow consider that a valid span context and we end up with a span in the context with a trace ID of 0, rather than a new trace ID being generated.

We can avoid this issue by setting the propagation styles back to "datadog,tracecontext". But it seems like the correct behavior would be if baggage is found but contains no span context data then it should be considered "span context not found" and a new span context should be created.

Reproduction Code

No response

Error Logs

No response

Go Env Output

No response

@chadawagner chadawagner added the bug unintended behavior that has to be fixed label May 27, 2025
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label May 27, 2025
@darccio darccio removed the needs-triage New issues that have not yet been triaged label Jun 2, 2025
@mtoffl01 mtoffl01 self-assigned this Jun 2, 2025
@mtoffl01
Copy link
Contributor

mtoffl01 commented Jun 2, 2025

Hi @chadawagner ,
Thanks for reaching out. We are in the process of fixing this. We will update you once the fix is complete. We apologize for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behavior that has to be fixed
Projects
None yet
Development

No branches or pull requests

3 participants