Skip to content

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

b = msgp.AppendUint32(b, index)
}
return b
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajgajg1134 I was under the impression we had to serialize the strings table as a slice of strings at the top of TracerPayload:

message TracerPayload {
 // array of strings referenced in this tracer payload, its chunks and spans
 repeated string strings = 1;

According to this function, we are either serializing the string the first time we write it or its index in next writes.

I'm unable to find where we are serializing the strings table, as I'm missing a line like these but for ID 1: https://github.com/DataDog/dd-trace-go/pull/3996/files#diff-9df81162cb99500ad1cb8173ef980e90d31d6be9ab6ebfd3942652102f50656eR199

o = msgp.AppendUint32(o, 1) // I'm expecting to see this but I didn't find it.
Image Image

Is this some kind of optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants