Skip to content

Conversation

darccio
Copy link
Member

@darccio darccio commented Oct 1, 2025

What does this PR do?

Sets a different direction for #3947 by getting payloadV1 closer to the RFC representation.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Copy link
Contributor

datadog-official bot commented Oct 1, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5078e30 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2025

Benchmarks

Benchmark execution time: 2025-10-06 13:21:18

Comparing candidate commit 5078e30 in PR branch dario.castane/v1-trace-protocol with baseline commit 60165d3 in branch hannahkm/implement-v1-serialization.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio darccio force-pushed the dario.castane/v1-trace-protocol branch 9 times, most recently from ea980a1 to 28382ec Compare October 3, 2025 20:09
@darccio darccio force-pushed the dario.castane/v1-trace-protocol branch from 28382ec to 5078e30 Compare October 6, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant