Skip to content

Conversation

ojproductions
Copy link

@ojproductions ojproductions commented Oct 14, 2025

What does this PR do?

Copies multivalue header changes made in datadog-lambda-go

Motivation

APMSVLS-226

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@ojproductions ojproductions requested a review from a team as a code owner October 14, 2025 20:47
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 14, 2025
@ojproductions ojproductions changed the title move changes from datadog-lambda-go into dd-trace-go contrib add multivalue headers changes from datadog-lambda-go Oct 14, 2025
@pr-commenter
Copy link

pr-commenter bot commented Oct 14, 2025

Benchmarks

Benchmark execution time: 2025-10-14 21:00:05

Comparing candidate commit aaed932 in PR branch onzia/multivalue-headers with baseline commit 781c7b7 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 23 metrics, 0 unstable metrics.

scenario:BenchmarkParallelMetrics/rate/get-handle-24

  • 🟥 execution_time [+1.490ns; +4.318ns] or [+2.123%; +6.152%]

@ojproductions ojproductions changed the title add multivalue headers changes from datadog-lambda-go feat; add multivalue headers changes from datadog-lambda-go Oct 14, 2025
@ojproductions ojproductions changed the title feat; add multivalue headers changes from datadog-lambda-go feat: add multivalue headers changes from datadog-lambda-go Oct 14, 2025
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants