-
Notifications
You must be signed in to change notification settings - Fork 306
[wip] LLM Observability SDK merge branch #8781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gary-huang
wants to merge
3
commits into
master
Choose a base branch
from
gary/llmobs-sdk-merge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~993cdbeffa, baseline=1.50.0-SNAPSHOT~3853c65296
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1031181
Total [baseline] (8.554 s) : 0, 8554400
Agent [candidate] (1.021 s) : 0, 1020590
Total [candidate] (8.497 s) : 0, 8497225
section iast
Agent [baseline] (1.156 s) : 0, 1156182
Total [baseline] (9.18 s) : 0, 9179847
Agent [candidate] (1.164 s) : 0, 1164216
Total [candidate] (9.248 s) : 0, 9248401
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.147 s) : 0, 1147495
Total [baseline] (9.118 s) : 0, 9117798
Agent [candidate] (1.153 s) : 0, 1153004
Total [candidate] (9.206 s) : 0, 9206423
section iast_TELEMETRY_OFF
Agent [baseline] (1.147 s) : 0, 1147460
Total [baseline] (9.239 s) : 0, 9239444
Agent [candidate] (1.144 s) : 0, 1144497
Total [candidate] (9.22 s) : 0, 9219972
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~993cdbeffa, baseline=1.50.0-SNAPSHOT~3853c65296
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.94 ms) : 0, 688940
BytebuddyAgent [candidate] (681.733 ms) : 0, 681733
GlobalTracer [baseline] (242.19 ms) : 0, 242190
GlobalTracer [candidate] (239.648 ms) : 0, 239648
AppSec [baseline] (57.918 ms) : 0, 57918
AppSec [candidate] (57.471 ms) : 0, 57471
Debugger [baseline] (6.208 ms) : 0, 6208
Debugger [candidate] (6.199 ms) : 0, 6199
Remote Config [baseline] (740.58 µs) : 0, 741
Remote Config [candidate] (718.554 µs) : 0, 719
Telemetry [baseline] (11.428 ms) : 0, 11428
Telemetry [candidate] (11.274 ms) : 0, 11274
section iast
BytebuddyAgent [baseline] (806.514 ms) : 0, 806514
BytebuddyAgent [candidate] (812.8 ms) : 0, 812800
GlobalTracer [baseline] (231.546 ms) : 0, 231546
GlobalTracer [candidate] (232.711 ms) : 0, 232711
IAST [baseline] (26.501 ms) : 0, 26501
IAST [candidate] (25.673 ms) : 0, 25673
AppSec [baseline] (53.512 ms) : 0, 53512
AppSec [candidate] (54.505 ms) : 0, 54505
Debugger [baseline] (5.989 ms) : 0, 5989
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (609.873 µs) : 0, 610
Remote Config [candidate] (625.088 µs) : 0, 625
Telemetry [baseline] (7.929 ms) : 0, 7929
Telemetry [candidate] (8.039 ms) : 0, 8039
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.907 ms) : 0, 799907
BytebuddyAgent [candidate] (802.851 ms) : 0, 802851
GlobalTracer [baseline] (230.391 ms) : 0, 230391
GlobalTracer [candidate] (231.576 ms) : 0, 231576
IAST [baseline] (26.205 ms) : 0, 26205
IAST [candidate] (28.051 ms) : 0, 28051
AppSec [baseline] (53.048 ms) : 0, 53048
AppSec [candidate] (52.339 ms) : 0, 52339
Debugger [baseline] (5.912 ms) : 0, 5912
Debugger [candidate] (6.03 ms) : 0, 6030
Remote Config [baseline] (657.282 µs) : 0, 657
Remote Config [candidate] (601.555 µs) : 0, 602
Telemetry [baseline] (7.885 ms) : 0, 7885
Telemetry [candidate] (7.975 ms) : 0, 7975
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.853 ms) : 0, 797853
BytebuddyAgent [candidate] (797.62 ms) : 0, 797620
GlobalTracer [baseline] (231.707 ms) : 0, 231707
GlobalTracer [candidate] (230.169 ms) : 0, 230169
IAST [baseline] (30.031 ms) : 0, 30031
IAST [candidate] (28.573 ms) : 0, 28573
AppSec [baseline] (49.8 ms) : 0, 49800
AppSec [candidate] (49.41 ms) : 0, 49410
Debugger [baseline] (6.008 ms) : 0, 6008
Debugger [candidate] (5.98 ms) : 0, 5980
Remote Config [baseline] (617.724 µs) : 0, 618
Remote Config [candidate] (603.034 µs) : 0, 603
Telemetry [baseline] (7.971 ms) : 0, 7971
Telemetry [candidate] (7.876 ms) : 0, 7876
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~993cdbeffa, baseline=1.50.0-SNAPSHOT~3853c65296
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020973
Total [baseline] (11.144 s) : 0, 11144026
Agent [candidate] (1.023 s) : 0, 1022898
Total [candidate] (11.123 s) : 0, 11122610
section appsec
Agent [baseline] (1.16 s) : 0, 1160250
Total [baseline] (11.29 s) : 0, 11290437
Agent [candidate] (1.165 s) : 0, 1165078
Total [candidate] (11.221 s) : 0, 11221329
section iast
Agent [baseline] (1.15 s) : 0, 1149796
Total [baseline] (11.479 s) : 0, 11478989
Agent [candidate] (1.15 s) : 0, 1150296
Total [candidate] (11.377 s) : 0, 11377464
section profiling
Agent [baseline] (1.265 s) : 0, 1264539
Total [baseline] (11.466 s) : 0, 11465879
Agent [candidate] (1.277 s) : 0, 1276966
Total [candidate] (11.508 s) : 0, 11507636
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~993cdbeffa, baseline=1.50.0-SNAPSHOT~3853c65296
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.964 ms) : 0, 682964
BytebuddyAgent [candidate] (684.033 ms) : 0, 684033
GlobalTracer [baseline] (240.369 ms) : 0, 240369
GlobalTracer [candidate] (240.503 ms) : 0, 240503
AppSec [baseline] (55.649 ms) : 0, 55649
AppSec [candidate] (56.364 ms) : 0, 56364
Debugger [baseline] (6.181 ms) : 0, 6181
Debugger [candidate] (6.221 ms) : 0, 6221
Remote Config [baseline] (748.894 µs) : 0, 749
Remote Config [candidate] (735.096 µs) : 0, 735
Telemetry [baseline] (11.47 ms) : 0, 11470
Telemetry [candidate] (11.453 ms) : 0, 11453
section appsec
BytebuddyAgent [baseline] (698.926 ms) : 0, 698926
BytebuddyAgent [candidate] (702.314 ms) : 0, 702314
GlobalTracer [baseline] (237.103 ms) : 0, 237103
GlobalTracer [candidate] (237.939 ms) : 0, 237939
AppSec [baseline] (175.715 ms) : 0, 175715
AppSec [candidate] (176.272 ms) : 0, 176272
Debugger [baseline] (5.97 ms) : 0, 5970
Debugger [candidate] (5.945 ms) : 0, 5945
Remote Config [baseline] (643.887 µs) : 0, 644
Remote Config [candidate] (645.614 µs) : 0, 646
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.328 ms) : 0, 7328
IAST [baseline] (21.856 ms) : 0, 21856
IAST [candidate] (21.961 ms) : 0, 21961
section iast
BytebuddyAgent [baseline] (801.631 ms) : 0, 801631
BytebuddyAgent [candidate] (801.787 ms) : 0, 801787
GlobalTracer [baseline] (231.354 ms) : 0, 231354
GlobalTracer [candidate] (230.348 ms) : 0, 230348
AppSec [baseline] (51.193 ms) : 0, 51193
AppSec [candidate] (50.692 ms) : 0, 50692
Debugger [baseline] (5.933 ms) : 0, 5933
Debugger [candidate] (6.034 ms) : 0, 6034
Remote Config [baseline] (606.927 µs) : 0, 607
Remote Config [candidate] (597.302 µs) : 0, 597
Telemetry [baseline] (7.918 ms) : 0, 7918
Telemetry [candidate] (8.042 ms) : 0, 8042
IAST [baseline] (27.653 ms) : 0, 27653
IAST [candidate] (29.214 ms) : 0, 29214
section profiling
BytebuddyAgent [baseline] (674.841 ms) : 0, 674841
BytebuddyAgent [candidate] (681.831 ms) : 0, 681831
GlobalTracer [baseline] (360.167 ms) : 0, 360167
GlobalTracer [candidate] (362.338 ms) : 0, 362338
AppSec [baseline] (61.669 ms) : 0, 61669
AppSec [candidate] (61.825 ms) : 0, 61825
Debugger [baseline] (6.03 ms) : 0, 6030
Debugger [candidate] (6.149 ms) : 0, 6149
Remote Config [baseline] (679.458 µs) : 0, 679
Remote Config [candidate] (669.984 µs) : 0, 670
Telemetry [baseline] (8.044 ms) : 0, 8044
Telemetry [candidate] (8.229 ms) : 0, 8229
ProfilingAgent [baseline] (102.394 ms) : 0, 102394
ProfilingAgent [candidate] (104.702 ms) : 0, 104702
Profiling [baseline] (102.418 ms) : 0, 102418
Profiling [candidate] (104.726 ms) : 0, 104726
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 0 metrics, 13 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~993cdbeffa, baseline=1.50.0-SNAPSHOT~3853c65296
dateFormat X
axisFormat %s
section baseline
no_agent (7.769 ms) : 7747, 7790
. : milestone, 7769,
appsec (60.459 ms) : 59620, 61298
. : milestone, 60459,
appsec_no_iast (69.305 ms) : 68323, 70287
. : milestone, 69305,
code_origins (84.96 ms) : 83291, 86629
. : milestone, 84960,
iast (77.542 ms) : 76298, 78786
. : milestone, 77542,
profiling (50.683 ms) : 49937, 51429
. : milestone, 50683,
tracing (13.182 ms) : 13062, 13303
. : milestone, 13182,
section candidate
no_agent (124.424 ms) : 121740, 127108
. : milestone, 124424,
appsec (142.386 ms) : 138381, 146391
. : milestone, 142386,
appsec_no_iast (143.276 ms) : 138154, 148398
. : milestone, 143276,
code_origins (151.012 ms) : 141287, 160738
. : milestone, 151012,
iast (147.855 ms) : 141267, 154443
. : milestone, 147855,
profiling (137.708 ms) : 134222, 141194
. : milestone, 137708,
tracing (130.322 ms) : 127277, 133367
. : milestone, 130322,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~993cdbeffa, baseline=1.50.0-SNAPSHOT~3853c65296
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (2.401 ms) : 2352, 2449
. : milestone, 2401,
iast (2.189 ms) : 2128, 2250
. : milestone, 2189,
iast_GLOBAL (2.231 ms) : 2170, 2292
. : milestone, 2231,
profiling (2.026 ms) : 1977, 2075
. : milestone, 2026,
tracing (2.014 ms) : 1966, 2061
. : milestone, 2014,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.394 ms) : 2346, 2443
. : milestone, 2394,
iast (2.183 ms) : 2122, 2245
. : milestone, 2183,
iast_GLOBAL (2.229 ms) : 2167, 2290
. : milestone, 2229,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (1.995 ms) : 1948, 2043
. : milestone, 1995,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~993cdbeffa, baseline=1.50.0-SNAPSHOT~3853c65296
dateFormat X
axisFormat %s
section baseline
no_agent (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
appsec (14.785 s) : 14785000, 14785000
. : milestone, 14785000,
iast (18.44 s) : 18440000, 18440000
. : milestone, 18440000,
iast_GLOBAL (18.215 s) : 18215000, 18215000
. : milestone, 18215000,
profiling (15.077 s) : 15077000, 15077000
. : milestone, 15077000,
tracing (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
section candidate
no_agent (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
appsec (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
iast (18.667 s) : 18667000, 18667000
. : milestone, 18667000,
iast_GLOBAL (17.724 s) : 17724000, 17724000
. : milestone, 17724000,
profiling (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
tracing (14.953 s) : 14953000, 14953000
. : milestone, 14953000,
|
* add APIs for llm obs * add llm message class to support llm spans * follow java convention of naming Id instead of ID * add codeowners
896f40a
to
2be1b73
Compare
* add APIs for llm obs * add llm message class to support llm spans * add llm message class to support llm spans * impl llmobs agent and llmobs apis * support llm messages with tool calls * handle default model name and provider * rm unneeded file * spotless * add APIs for llm obs sdk (#8135) * add APIs for llm obs * add llm message class to support llm spans * follow java convention of naming Id instead of ID * add codeowners * rename ID to Id according to java naming conventions * Undo change to integrations-core submodule * fix build gradle * rm empty line * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add APIs for llm obs
add llm message class to support llm spans
follow java convention of naming Id instead of ID
add codeowners
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]