-
Notifications
You must be signed in to change notification settings - Fork 304
Support attaching tags to telemetry logs #8921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smola
wants to merge
2
commits into
master
Choose a base branch
from
smola/telemetry-logs-tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezen-datadog
approved these changes
Jun 4, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~05a6834a0b, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020889
Total [baseline] (11.071 s) : 0, 11071337
Agent [candidate] (1.031 s) : 0, 1030866
Total [candidate] (11.08 s) : 0, 11080383
section appsec
Agent [baseline] (1.165 s) : 0, 1164513
Total [baseline] (11.227 s) : 0, 11227217
Agent [candidate] (1.166 s) : 0, 1166356
Total [candidate] (11.295 s) : 0, 11295125
section iast
Agent [baseline] (1.152 s) : 0, 1152034
Total [baseline] (11.356 s) : 0, 11355763
Agent [candidate] (1.149 s) : 0, 1148800
Total [candidate] (11.305 s) : 0, 11304777
section profiling
Agent [baseline] (1.276 s) : 0, 1275713
Total [baseline] (11.531 s) : 0, 11531121
Agent [candidate] (1.271 s) : 0, 1271021
Total [candidate] (11.479 s) : 0, 11479002
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~05a6834a0b, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.163 ms) : 0, 682163
BytebuddyAgent [candidate] (688.62 ms) : 0, 688620
GlobalTracer [baseline] (239.791 ms) : 0, 239791
GlobalTracer [candidate] (241.824 ms) : 0, 241824
AppSec [baseline] (58.052 ms) : 0, 58052
AppSec [candidate] (56.72 ms) : 0, 56720
Debugger [baseline] (6.155 ms) : 0, 6155
Debugger [candidate] (6.269 ms) : 0, 6269
Remote Config [baseline] (747.501 µs) : 0, 748
Remote Config [candidate] (744.165 µs) : 0, 744
Telemetry [baseline] (10.513 ms) : 0, 10513
Telemetry [candidate] (12.975 ms) : 0, 12975
section appsec
BytebuddyAgent [baseline] (702.13 ms) : 0, 702130
BytebuddyAgent [candidate] (703.48 ms) : 0, 703480
GlobalTracer [baseline] (237.514 ms) : 0, 237514
GlobalTracer [candidate] (238.16 ms) : 0, 238160
AppSec [baseline] (176.27 ms) : 0, 176270
AppSec [candidate] (175.862 ms) : 0, 175862
Debugger [baseline] (6.008 ms) : 0, 6008
Debugger [candidate] (6.341 ms) : 0, 6341
Remote Config [baseline] (620.695 µs) : 0, 621
Remote Config [candidate] (625.208 µs) : 0, 625
Telemetry [baseline] (7.398 ms) : 0, 7398
Telemetry [candidate] (7.342 ms) : 0, 7342
IAST [baseline] (21.884 ms) : 0, 21884
IAST [candidate] (21.812 ms) : 0, 21812
section iast
BytebuddyAgent [baseline] (803.015 ms) : 0, 803015
BytebuddyAgent [candidate] (800.55 ms) : 0, 800550
GlobalTracer [baseline] (230.991 ms) : 0, 230991
GlobalTracer [candidate] (230.773 ms) : 0, 230773
AppSec [baseline] (54.49 ms) : 0, 54490
AppSec [candidate] (51.885 ms) : 0, 51885
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (5.982 ms) : 0, 5982
Remote Config [baseline] (608.884 µs) : 0, 609
Remote Config [candidate] (591.962 µs) : 0, 592
Telemetry [baseline] (7.92 ms) : 0, 7920
Telemetry [candidate] (7.918 ms) : 0, 7918
IAST [baseline] (25.414 ms) : 0, 25414
IAST [candidate] (27.639 ms) : 0, 27639
section profiling
BytebuddyAgent [baseline] (680.741 ms) : 0, 680741
BytebuddyAgent [candidate] (679.53 ms) : 0, 679530
GlobalTracer [baseline] (362.522 ms) : 0, 362522
GlobalTracer [candidate] (361.932 ms) : 0, 361932
AppSec [baseline] (62.213 ms) : 0, 62213
AppSec [candidate] (61.541 ms) : 0, 61541
Debugger [baseline] (6.134 ms) : 0, 6134
Debugger [candidate] (6.031 ms) : 0, 6031
Remote Config [baseline] (655.885 µs) : 0, 656
Remote Config [candidate] (632.529 µs) : 0, 633
Telemetry [baseline] (8.133 ms) : 0, 8133
Telemetry [candidate] (8.028 ms) : 0, 8028
ProfilingAgent [baseline] (104.22 ms) : 0, 104220
ProfilingAgent [candidate] (102.201 ms) : 0, 102201
Profiling [baseline] (104.245 ms) : 0, 104245
Profiling [candidate] (102.224 ms) : 0, 102224
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~05a6834a0b, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024097
Total [baseline] (8.54 s) : 0, 8540477
Agent [candidate] (1.026 s) : 0, 1025559
Total [candidate] (8.528 s) : 0, 8527741
section iast
Agent [baseline] (1.158 s) : 0, 1157850
Total [baseline] (9.165 s) : 0, 9165440
Agent [candidate] (1.149 s) : 0, 1149392
Total [candidate] (9.148 s) : 0, 9147698
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.157 s) : 0, 1156789
Total [baseline] (9.162 s) : 0, 9161951
Agent [candidate] (1.152 s) : 0, 1151606
Total [candidate] (9.14 s) : 0, 9140481
section iast_TELEMETRY_OFF
Agent [baseline] (1.149 s) : 0, 1148603
Total [baseline] (9.186 s) : 0, 9185799
Agent [candidate] (1.149 s) : 0, 1149070
Total [candidate] (9.261 s) : 0, 9260733
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~05a6834a0b, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.289 ms) : 0, 686289
BytebuddyAgent [candidate] (684.244 ms) : 0, 684244
GlobalTracer [baseline] (241.039 ms) : 0, 241039
GlobalTracer [candidate] (240.86 ms) : 0, 240860
AppSec [baseline] (56.102 ms) : 0, 56102
AppSec [candidate] (57.175 ms) : 0, 57175
Debugger [baseline] (6.244 ms) : 0, 6244
Debugger [candidate] (6.192 ms) : 0, 6192
Remote Config [baseline] (737.008 µs) : 0, 737
Remote Config [candidate] (717.463 µs) : 0, 717
Telemetry [baseline] (9.943 ms) : 0, 9943
Telemetry [candidate] (12.813 ms) : 0, 12813
section iast
BytebuddyAgent [baseline] (808.266 ms) : 0, 808266
BytebuddyAgent [candidate] (801.39 ms) : 0, 801390
GlobalTracer [baseline] (232.61 ms) : 0, 232610
GlobalTracer [candidate] (230.401 ms) : 0, 230401
IAST [baseline] (27.77 ms) : 0, 27770
IAST [candidate] (25.478 ms) : 0, 25478
AppSec [baseline] (51.259 ms) : 0, 51259
AppSec [candidate] (54.307 ms) : 0, 54307
Debugger [baseline] (5.908 ms) : 0, 5908
Debugger [candidate] (5.96 ms) : 0, 5960
Remote Config [baseline] (587.817 µs) : 0, 588
Remote Config [candidate] (587.898 µs) : 0, 588
Telemetry [baseline] (7.851 ms) : 0, 7851
Telemetry [candidate] (7.821 ms) : 0, 7821
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.739 ms) : 0, 806739
BytebuddyAgent [candidate] (802.132 ms) : 0, 802132
GlobalTracer [baseline] (231.856 ms) : 0, 231856
GlobalTracer [candidate] (231.131 ms) : 0, 231131
IAST [baseline] (28.072 ms) : 0, 28072
IAST [candidate] (27.939 ms) : 0, 27939
AppSec [baseline] (51.959 ms) : 0, 51959
AppSec [candidate] (52.079 ms) : 0, 52079
Debugger [baseline] (5.992 ms) : 0, 5992
Debugger [candidate] (6.099 ms) : 0, 6099
Remote Config [baseline] (601.244 µs) : 0, 601
Remote Config [candidate] (609.033 µs) : 0, 609
Telemetry [baseline] (7.966 ms) : 0, 7966
Telemetry [candidate] (8.095 ms) : 0, 8095
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.15 ms) : 0, 800150
BytebuddyAgent [candidate] (800.716 ms) : 0, 800716
GlobalTracer [baseline] (231.58 ms) : 0, 231580
GlobalTracer [candidate] (231.339 ms) : 0, 231339
IAST [baseline] (28.87 ms) : 0, 28870
IAST [candidate] (30.45 ms) : 0, 30450
AppSec [baseline] (49.992 ms) : 0, 49992
AppSec [candidate] (48.593 ms) : 0, 48593
Debugger [baseline] (6.013 ms) : 0, 6013
Debugger [candidate] (5.982 ms) : 0, 5982
Remote Config [baseline] (611.751 µs) : 0, 612
Remote Config [candidate] (590.933 µs) : 0, 591
Telemetry [baseline] (7.921 ms) : 0, 7921
Telemetry [candidate] (7.843 ms) : 0, 7843
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 0 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~05a6834a0b, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (8.022 ms) : 8000, 8043
. : milestone, 8022,
appsec (45.543 ms) : 44686, 46400
. : milestone, 45543,
appsec_no_iast (54.024 ms) : 52858, 55191
. : milestone, 54024,
code_origins (67.118 ms) : 65276, 68960
. : milestone, 67118,
iast (61.075 ms) : 59311, 62838
. : milestone, 61075,
profiling (11.502 ms) : 11398, 11605
. : milestone, 11502,
tracing (8.183 ms) : 8157, 8210
. : milestone, 8183,
section candidate
no_agent (99.907 ms) : 97387, 102427
. : milestone, 99907,
appsec (122.32 ms) : 117967, 126673
. : milestone, 122320,
appsec_no_iast (126.119 ms) : 121538, 130700
. : milestone, 126119,
code_origins (146.206 ms) : 136405, 156007
. : milestone, 146206,
iast (132.177 ms) : 126377, 137977
. : milestone, 132177,
profiling (113.352 ms) : 109912, 116793
. : milestone, 113352,
tracing (104.973 ms) : 102153, 107792
. : milestone, 104973,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~05a6834a0b, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.425 ms) : 2376, 2475
. : milestone, 2425,
iast (2.212 ms) : 2149, 2275
. : milestone, 2212,
iast_GLOBAL (2.254 ms) : 2191, 2317
. : milestone, 2254,
profiling (2.073 ms) : 2022, 2125
. : milestone, 2073,
tracing (2.02 ms) : 1972, 2068
. : milestone, 2020,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.412 ms) : 2363, 2462
. : milestone, 2412,
iast (2.217 ms) : 2154, 2280
. : milestone, 2217,
iast_GLOBAL (2.249 ms) : 2186, 2312
. : milestone, 2249,
profiling (2.038 ms) : 1987, 2089
. : milestone, 2038,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~05a6834a0b, baseline=1.50.0-SNAPSHOT~7787af738f
dateFormat X
axisFormat %s
section baseline
no_agent (15.601 s) : 15601000, 15601000
. : milestone, 15601000,
appsec (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
iast (18.856 s) : 18856000, 18856000
. : milestone, 18856000,
iast_GLOBAL (18.163 s) : 18163000, 18163000
. : milestone, 18163000,
profiling (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
tracing (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
section candidate
no_agent (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
appsec (14.632 s) : 14632000, 14632000
. : milestone, 14632000,
iast (19.08 s) : 19080000, 19080000
. : milestone, 19080000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
. : milestone, 18061000,
profiling (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
tracing (14.817 s) : 14817000, 14817000
. : milestone, 14817000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add support for
LogCollector
to create telemetry logs with tags. Tags are defined as a string, a comma-separated list, e.g.tag1:value1,tag2:value2
.Motivation
We have new use cases in AppSec to send telemetry logs with more structured data in tags. This functionality was already in our telemetry system, but not exposed in
internal-api
.This is still not exposed via regular SLF4J logging integration. For the time being, if one needs this, they'll have to use the telemetry-specific interface in this PR.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]