-
Notifications
You must be signed in to change notification settings - Fork 306
Default obfuscation regexp update #8937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default obfuscation regexp update #8937
Conversation
f0f5955
to
5186564
Compare
dd-java-agent/appsec/src/jmh/java/datadog/appsec/benchmark/WafBenchmark.java
Outdated
Show resolved
Hide resolved
5186564
to
24555b6
Compare
6c47b1e
to
42f13c9
Compare
22f3cfd
to
5646b68
Compare
5b79c2f
to
8212f64
Compare
bad8ea7
to
2893e4c
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~6e43ba5cce, baseline=1.51.0-SNAPSHOT~d78bb4d2b2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001347
Total [baseline] (10.619 s) : 0, 10619497
Agent [candidate] (996.149 ms) : 0, 996149
Total [candidate] (10.666 s) : 0, 10666437
section appsec
Agent [baseline] (1.177 s) : 0, 1177087
Total [baseline] (10.734 s) : 0, 10734142
Agent [candidate] (1.187 s) : 0, 1187061
Total [candidate] (10.732 s) : 0, 10732354
section iast
Agent [baseline] (1.138 s) : 0, 1137545
Total [baseline] (10.823 s) : 0, 10822782
Agent [candidate] (1.135 s) : 0, 1134856
Total [candidate] (10.915 s) : 0, 10915363
section profiling
Agent [baseline] (1.251 s) : 0, 1250656
Total [baseline] (11.073 s) : 0, 11073137
Agent [candidate] (1.241 s) : 0, 1240942
Total [candidate] (10.974 s) : 0, 10974190
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~6e43ba5cce, baseline=1.51.0-SNAPSHOT~d78bb4d2b2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.471 ms) : 0, 691471
BytebuddyAgent [candidate] (687.185 ms) : 0, 687185
GlobalTracer [baseline] (243.65 ms) : 0, 243650
GlobalTracer [candidate] (243.118 ms) : 0, 243118
AppSec [baseline] (30.267 ms) : 0, 30267
AppSec [candidate] (30.104 ms) : 0, 30104
Debugger [baseline] (6.103 ms) : 0, 6103
Debugger [candidate] (6.047 ms) : 0, 6047
Remote Config [baseline] (649.261 µs) : 0, 649
Remote Config [candidate] (650.588 µs) : 0, 651
Telemetry [baseline] (8.346 ms) : 0, 8346
Telemetry [candidate] (8.177 ms) : 0, 8177
section appsec
BytebuddyAgent [baseline] (714.653 ms) : 0, 714653
BytebuddyAgent [candidate] (720.262 ms) : 0, 720262
GlobalTracer [baseline] (236.512 ms) : 0, 236512
GlobalTracer [candidate] (238.669 ms) : 0, 238669
IAST [baseline] (21.953 ms) : 0, 21953
IAST [candidate] (22.354 ms) : 0, 22354
AppSec [baseline] (168.463 ms) : 0, 168463
AppSec [candidate] (169.874 ms) : 0, 169874
Debugger [baseline] (5.858 ms) : 0, 5858
Debugger [candidate] (5.885 ms) : 0, 5885
Remote Config [baseline] (602.12 µs) : 0, 602
Remote Config [candidate] (619.176 µs) : 0, 619
Telemetry [baseline] (8.131 ms) : 0, 8131
Telemetry [candidate] (8.301 ms) : 0, 8301
section iast
BytebuddyAgent [baseline] (813.389 ms) : 0, 813389
BytebuddyAgent [candidate] (811.999 ms) : 0, 811999
GlobalTracer [baseline] (233.376 ms) : 0, 233376
GlobalTracer [candidate] (232.765 ms) : 0, 232765
IAST [baseline] (25.495 ms) : 0, 25495
IAST [candidate] (29.923 ms) : 0, 29923
AppSec [baseline] (29.983 ms) : 0, 29983
AppSec [candidate] (25.035 ms) : 0, 25035
Debugger [baseline] (5.787 ms) : 0, 5787
Debugger [candidate] (5.817 ms) : 0, 5817
Remote Config [baseline] (572.176 µs) : 0, 572
Remote Config [candidate] (590.698 µs) : 0, 591
Telemetry [baseline] (7.956 ms) : 0, 7956
Telemetry [candidate] (7.875 ms) : 0, 7875
section profiling
BytebuddyAgent [baseline] (682.446 ms) : 0, 682446
BytebuddyAgent [candidate] (677.311 ms) : 0, 677311
GlobalTracer [baseline] (363.592 ms) : 0, 363592
GlobalTracer [candidate] (360.882 ms) : 0, 360882
AppSec [baseline] (34.118 ms) : 0, 34118
AppSec [candidate] (32.379 ms) : 0, 32379
Debugger [baseline] (8.303 ms) : 0, 8303
Debugger [candidate] (9.658 ms) : 0, 9658
Remote Config [baseline] (1.354 ms) : 0, 1354
Remote Config [candidate] (668.133 µs) : 0, 668
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (9.387 ms) : 0, 9387
ProfilingAgent [baseline] (103.275 ms) : 0, 103275
ProfilingAgent [candidate] (102.075 ms) : 0, 102075
Profiling [baseline] (103.3 ms) : 0, 103300
Profiling [candidate] (102.1 ms) : 0, 102100
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~6e43ba5cce, baseline=1.51.0-SNAPSHOT~d78bb4d2b2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (990.842 ms) : 0, 990842
Total [baseline] (8.509 s) : 0, 8508905
Agent [candidate] (1.003 s) : 0, 1003156
Total [candidate] (8.573 s) : 0, 8573451
section iast
Agent [baseline] (1.136 s) : 0, 1135663
Total [baseline] (9.272 s) : 0, 9271841
Agent [candidate] (1.137 s) : 0, 1136627
Total [candidate] (9.212 s) : 0, 9211767
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~6e43ba5cce, baseline=1.51.0-SNAPSHOT~d78bb4d2b2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.489 ms) : 0, 684489
BytebuddyAgent [candidate] (691.948 ms) : 0, 691948
GlobalTracer [baseline] (240.725 ms) : 0, 240725
GlobalTracer [candidate] (244.767 ms) : 0, 244767
AppSec [baseline] (29.95 ms) : 0, 29950
AppSec [candidate] (30.354 ms) : 0, 30354
Debugger [baseline] (6.02 ms) : 0, 6020
Debugger [candidate] (6.093 ms) : 0, 6093
Remote Config [baseline] (648.382 µs) : 0, 648
Remote Config [candidate] (655.833 µs) : 0, 656
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (8.265 ms) : 0, 8265
section iast
BytebuddyAgent [baseline] (812.275 ms) : 0, 812275
BytebuddyAgent [candidate] (812.727 ms) : 0, 812727
GlobalTracer [baseline] (232.856 ms) : 0, 232856
GlobalTracer [candidate] (233.264 ms) : 0, 233264
IAST [baseline] (26.995 ms) : 0, 26995
IAST [candidate] (27.873 ms) : 0, 27873
AppSec [baseline] (28.371 ms) : 0, 28371
AppSec [candidate] (27.576 ms) : 0, 27576
Debugger [baseline] (5.819 ms) : 0, 5819
Debugger [candidate] (5.813 ms) : 0, 5813
Remote Config [baseline] (582.384 µs) : 0, 582
Remote Config [candidate] (578.66 µs) : 0, 579
Telemetry [baseline] (7.912 ms) : 0, 7912
Telemetry [candidate] (7.874 ms) : 0, 7874
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~6e43ba5cce, baseline=1.51.0-SNAPSHOT~d78bb4d2b2
dateFormat X
axisFormat %s
section baseline
no_agent (37.125 ms) : 36831, 37420
. : milestone, 37125,
appsec (48.052 ms) : 47613, 48490
. : milestone, 48052,
code_origins (45.724 ms) : 45344, 46105
. : milestone, 45724,
iast (44.479 ms) : 44087, 44871
. : milestone, 44479,
profiling (48.817 ms) : 48357, 49276
. : milestone, 48817,
tracing (44.216 ms) : 43846, 44585
. : milestone, 44216,
section candidate
no_agent (36.827 ms) : 36530, 37125
. : milestone, 36827,
appsec (47.157 ms) : 46735, 47578
. : milestone, 47157,
code_origins (44.873 ms) : 44491, 45256
. : milestone, 44873,
iast (44.161 ms) : 43764, 44559
. : milestone, 44161,
profiling (50.865 ms) : 50363, 51367
. : milestone, 50865,
tracing (43.598 ms) : 43241, 43955
. : milestone, 43598,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~6e43ba5cce, baseline=1.51.0-SNAPSHOT~d78bb4d2b2
dateFormat X
axisFormat %s
section baseline
no_agent (4.371 ms) : 4319, 4424
. : milestone, 4371,
iast (9.25 ms) : 9101, 9399
. : milestone, 9250,
iast_FULL (13.967 ms) : 13697, 14237
. : milestone, 13967,
iast_GLOBAL (10.142 ms) : 9963, 10321
. : milestone, 10142,
profiling (8.631 ms) : 8501, 8762
. : milestone, 8631,
tracing (7.61 ms) : 7500, 7720
. : milestone, 7610,
section candidate
no_agent (4.461 ms) : 4408, 4514
. : milestone, 4461,
iast (9.229 ms) : 9070, 9387
. : milestone, 9229,
iast_FULL (13.467 ms) : 13204, 13731
. : milestone, 13467,
iast_GLOBAL (10.124 ms) : 9946, 10302
. : milestone, 10124,
profiling (8.839 ms) : 8693, 8984
. : milestone, 8839,
tracing (7.903 ms) : 7785, 8020
. : milestone, 7903,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~6e43ba5cce, baseline=1.51.0-SNAPSHOT~d78bb4d2b2
dateFormat X
axisFormat %s
section baseline
no_agent (14.82 s) : 14820000, 14820000
. : milestone, 14820000,
appsec (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
iast (18.494 s) : 18494000, 18494000
. : milestone, 18494000,
iast_GLOBAL (17.823 s) : 17823000, 17823000
. : milestone, 17823000,
profiling (15.258 s) : 15258000, 15258000
. : milestone, 15258000,
tracing (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
section candidate
no_agent (14.906 s) : 14906000, 14906000
. : milestone, 14906000,
appsec (14.826 s) : 14826000, 14826000
. : milestone, 14826000,
iast (18.499 s) : 18499000, 18499000
. : milestone, 18499000,
iast_GLOBAL (18.068 s) : 18068000, 18068000
. : milestone, 18068000,
profiling (15.652 s) : 15652000, 15652000
. : milestone, 15652000,
tracing (14.906 s) : 14906000, 14906000
. : milestone, 14906000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~6e43ba5cce, baseline=1.51.0-SNAPSHOT~d78bb4d2b2
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.387 ms) : 2338, 2436
. : milestone, 2387,
iast (2.192 ms) : 2131, 2253
. : milestone, 2192,
iast_GLOBAL (2.231 ms) : 2169, 2293
. : milestone, 2231,
profiling (2.022 ms) : 1973, 2072
. : milestone, 2022,
tracing (2.018 ms) : 1970, 2066
. : milestone, 2018,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.4 ms) : 2352, 2449
. : milestone, 2400,
iast (2.187 ms) : 2125, 2248
. : milestone, 2187,
iast_GLOBAL (2.221 ms) : 2159, 2283
. : milestone, 2221,
profiling (2.055 ms) : 2004, 2106
. : milestone, 2055,
tracing (2.012 ms) : 1964, 2059
. : milestone, 2012,
|
2893e4c
to
60d5eee
Compare
d802d00
to
d5435c9
Compare
d1dbd04
to
2856a4e
Compare
Signed-off-by: sezen.leblay <sezen.leblay@datadoghq.com>
5734454
to
6e43ba5
Compare
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
Updates libddwaf-java version to have the new regex key for obfuscation
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-57270