Remove telemetry markers from log output #9112
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~4ceb9dfb3f, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001463
Total [baseline] (8.636 s) : 0, 8636412
Agent [candidate] (998.77 ms) : 0, 998770
Total [candidate] (8.585 s) : 0, 8585335
section iast
Agent [baseline] (1.138 s) : 0, 1137693
Total [baseline] (9.297 s) : 0, 9296956
Agent [candidate] (1.136 s) : 0, 1136087
Total [candidate] (9.264 s) : 0, 9264179
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~4ceb9dfb3f, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.744 ms) : 0, 691744
BytebuddyAgent [candidate] (689.724 ms) : 0, 689724
GlobalTracer [baseline] (243.183 ms) : 0, 243183
GlobalTracer [candidate] (242.916 ms) : 0, 242916
AppSec [baseline] (30.565 ms) : 0, 30565
AppSec [candidate] (30.356 ms) : 0, 30356
Debugger [baseline] (6.056 ms) : 0, 6056
Debugger [candidate] (6.03 ms) : 0, 6030
Remote Config [baseline] (683.3 µs) : 0, 683
Remote Config [candidate] (679.282 µs) : 0, 679
Telemetry [baseline] (8.248 ms) : 0, 8248
Telemetry [candidate] (8.24 ms) : 0, 8240
section iast
BytebuddyAgent [baseline] (811.353 ms) : 0, 811353
BytebuddyAgent [candidate] (809.889 ms) : 0, 809889
GlobalTracer [baseline] (233.557 ms) : 0, 233557
GlobalTracer [candidate] (233.348 ms) : 0, 233348
IAST [baseline] (27.017 ms) : 0, 27017
IAST [candidate] (26.172 ms) : 0, 26172
AppSec [baseline] (29.54 ms) : 0, 29540
AppSec [candidate] (31.394 ms) : 0, 31394
Debugger [baseline] (6.712 ms) : 0, 6712
Debugger [candidate] (5.825 ms) : 0, 5825
Remote Config [baseline] (588.015 µs) : 0, 588
Remote Config [candidate] (578.21 µs) : 0, 578
Telemetry [baseline] (8.046 ms) : 0, 8046
Telemetry [candidate] (7.983 ms) : 0, 7983
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~4ceb9dfb3f, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.416 ms) : 0, 996416
Total [baseline] (10.639 s) : 0, 10639088
Agent [candidate] (1.004 s) : 0, 1003613
Total [candidate] (10.685 s) : 0, 10684573
section appsec
Agent [baseline] (1.175 s) : 0, 1175444
Total [baseline] (10.761 s) : 0, 10761286
Agent [candidate] (1.178 s) : 0, 1177940
Total [candidate] (10.828 s) : 0, 10828216
section iast
Agent [baseline] (1.135 s) : 0, 1135239
Total [baseline] (10.879 s) : 0, 10879081
Agent [candidate] (1.135 s) : 0, 1135096
Total [candidate] (10.908 s) : 0, 10907770
section profiling
Agent [baseline] (1.25 s) : 0, 1250073
Total [baseline] (10.95 s) : 0, 10950176
Agent [candidate] (1.247 s) : 0, 1246780
Total [candidate] (10.931 s) : 0, 10931380
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~4ceb9dfb3f, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.149 ms) : 0, 688149
BytebuddyAgent [candidate] (693.366 ms) : 0, 693366
GlobalTracer [baseline] (242.29 ms) : 0, 242290
GlobalTracer [candidate] (243.697 ms) : 0, 243697
AppSec [baseline] (30.146 ms) : 0, 30146
AppSec [candidate] (30.565 ms) : 0, 30565
Debugger [baseline] (6.071 ms) : 0, 6071
Debugger [candidate] (6.068 ms) : 0, 6068
Remote Config [baseline] (678.005 µs) : 0, 678
Remote Config [candidate] (675.182 µs) : 0, 675
Telemetry [baseline] (8.22 ms) : 0, 8220
Telemetry [candidate] (8.29 ms) : 0, 8290
section appsec
BytebuddyAgent [baseline] (710.111 ms) : 0, 710111
BytebuddyAgent [candidate] (712.023 ms) : 0, 712023
GlobalTracer [baseline] (235.236 ms) : 0, 235236
GlobalTracer [candidate] (235.84 ms) : 0, 235840
AppSec [baseline] (171.652 ms) : 0, 171652
AppSec [candidate] (171.516 ms) : 0, 171516
Debugger [baseline] (5.727 ms) : 0, 5727
Debugger [candidate] (5.736 ms) : 0, 5736
Remote Config [baseline] (602.674 µs) : 0, 603
Remote Config [candidate] (595.869 µs) : 0, 596
Telemetry [baseline] (8.042 ms) : 0, 8042
Telemetry [candidate] (8.04 ms) : 0, 8040
IAST [baseline] (23.236 ms) : 0, 23236
IAST [candidate] (23.309 ms) : 0, 23309
section iast
BytebuddyAgent [baseline] (809.113 ms) : 0, 809113
BytebuddyAgent [candidate] (808.463 ms) : 0, 808463
GlobalTracer [baseline] (233.769 ms) : 0, 233769
GlobalTracer [candidate] (233.481 ms) : 0, 233481
AppSec [baseline] (27.729 ms) : 0, 27729
AppSec [candidate] (28.428 ms) : 0, 28428
Debugger [baseline] (5.846 ms) : 0, 5846
Debugger [candidate] (5.901 ms) : 0, 5901
Remote Config [baseline] (589.224 µs) : 0, 589
Remote Config [candidate] (586.677 µs) : 0, 587
Telemetry [baseline] (7.984 ms) : 0, 7984
Telemetry [candidate] (8.114 ms) : 0, 8114
IAST [baseline] (29.394 ms) : 0, 29394
IAST [candidate] (29.257 ms) : 0, 29257
section profiling
ProfilingAgent [baseline] (103.27 ms) : 0, 103270
ProfilingAgent [candidate] (103.47 ms) : 0, 103470
BytebuddyAgent [baseline] (681.134 ms) : 0, 681134
BytebuddyAgent [candidate] (679.399 ms) : 0, 679399
GlobalTracer [baseline] (363.747 ms) : 0, 363747
GlobalTracer [candidate] (361.991 ms) : 0, 361991
AppSec [baseline] (31.726 ms) : 0, 31726
AppSec [candidate] (30.952 ms) : 0, 30952
Debugger [baseline] (10.658 ms) : 0, 10658
Debugger [candidate] (12.728 ms) : 0, 12728
Remote Config [baseline] (672.737 µs) : 0, 673
Remote Config [candidate] (676.667 µs) : 0, 677
Telemetry [baseline] (8.721 ms) : 0, 8721
Telemetry [candidate] (9.005 ms) : 0, 9005
Profiling [baseline] (103.295 ms) : 0, 103295
Profiling [candidate] (103.494 ms) : 0, 103494
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ceb9dfb3f, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
dateFormat X
axisFormat %s
section baseline
no_agent (37.515 ms) : 37206, 37825
. : milestone, 37515,
appsec (48.822 ms) : 48401, 49243
. : milestone, 48822,
code_origins (44.657 ms) : 44273, 45040
. : milestone, 44657,
iast (44.507 ms) : 44121, 44893
. : milestone, 44507,
profiling (47.998 ms) : 47554, 48441
. : milestone, 47998,
tracing (42.874 ms) : 42504, 43243
. : milestone, 42874,
section candidate
no_agent (37.99 ms) : 37682, 38297
. : milestone, 37990,
appsec (45.17 ms) : 44780, 45560
. : milestone, 45170,
code_origins (45.976 ms) : 45566, 46386
. : milestone, 45976,
iast (43.414 ms) : 43038, 43790
. : milestone, 43414,
profiling (49.016 ms) : 48581, 49451
. : milestone, 49016,
tracing (44.108 ms) : 43726, 44490
. : milestone, 44108,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ceb9dfb3f, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
dateFormat X
axisFormat %s
section baseline
no_agent (4.425 ms) : 4375, 4475
. : milestone, 4425,
iast (9.133 ms) : 8980, 9287
. : milestone, 9133,
iast_FULL (13.625 ms) : 13354, 13895
. : milestone, 13625,
iast_GLOBAL (10.299 ms) : 10120, 10478
. : milestone, 10299,
profiling (8.927 ms) : 8783, 9072
. : milestone, 8927,
tracing (7.858 ms) : 7747, 7970
. : milestone, 7858,
section candidate
no_agent (4.629 ms) : 4570, 4687
. : milestone, 4629,
iast (9.344 ms) : 9190, 9498
. : milestone, 9344,
iast_FULL (14.061 ms) : 13786, 14336
. : milestone, 14061,
iast_GLOBAL (10.51 ms) : 10324, 10695
. : milestone, 10510,
profiling (8.59 ms) : 8450, 8730
. : milestone, 8590,
tracing (7.648 ms) : 7532, 7764
. : milestone, 7648,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ceb9dfb3f, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
dateFormat X
axisFormat %s
section baseline
no_agent (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
appsec (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
iast (18.798 s) : 18798000, 18798000
. : milestone, 18798000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
tracing (14.8 s) : 14800000, 14800000
. : milestone, 14800000,
section candidate
no_agent (15.639 s) : 15639000, 15639000
. : milestone, 15639000,
appsec (15.167 s) : 15167000, 15167000
. : milestone, 15167000,
iast (18.099 s) : 18099000, 18099000
. : milestone, 18099000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
. : milestone, 17982000,
profiling (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
tracing (15.012 s) : 15012000, 15012000
. : milestone, 15012000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~4ceb9dfb3f, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.389 ms) : 2340, 2439
. : milestone, 2389,
iast (2.173 ms) : 2112, 2235
. : milestone, 2173,
iast_GLOBAL (2.221 ms) : 2159, 2284
. : milestone, 2221,
profiling (2.033 ms) : 1983, 2084
. : milestone, 2033,
tracing (1.99 ms) : 1942, 2038
. : milestone, 1990,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.385 ms) : 2336, 2434
. : milestone, 2385,
iast (2.174 ms) : 2112, 2236
. : milestone, 2174,
iast_GLOBAL (2.226 ms) : 2164, 2289
. : milestone, 2226,
profiling (2.034 ms) : 1983, 2085
. : milestone, 2034,
tracing (1.998 ms) : 1950, 2046
. : milestone, 1998,
|
bric3
reviewed
Jul 16, 2025
Comment on lines
+51
to
+57
| private Marker filterTelemetryLogMarkers(Marker marker) { | ||
| if (marker == LogCollector.EXCLUDE_TELEMETRY || marker == LogCollector.SEND_TELEMETRY) { | ||
| // Do not log telemetry markers | ||
| return null; | ||
| } | ||
| return marker; | ||
| } |
There was a problem hiding this comment.
suggestion: What about injecting a specific helper for telemetry logger that removes the marker ? E.g. in the DDLoggerFactory, by wrapping the helper for the telemetry logger, the log function could just drop the telemetry markers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Remove telemetry markers from log calls after they've been forwarded to telemetry. This avoids telemetry markers showing up as log levels in the output format.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-53169